Re: [PATCH] tty/hvc_console: fix console lock ordering with spinlock

2017-04-04 Thread Denis Kirjanov
On 4/4/17, Michael Ellerman wrote: > Denis Kirjanov writes: > >> hvc_remove() takes a spin lock first then acquires the console >> semaphore. This situation can easily lead to a deadlock scenario >> where we call scheduler with spin lock held. > > Have you actually hit the deadlock? Because that

Re: [PATCH] tty/hvc_console: fix console lock ordering with spinlock

2017-04-04 Thread Michael Ellerman
Denis Kirjanov writes: > hvc_remove() takes a spin lock first then acquires the console > semaphore. This situation can easily lead to a deadlock scenario > where we call scheduler with spin lock held. Have you actually hit the deadlock? Because that code's been like that for years and I've neve