Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

2016-01-26 Thread Scott Wood
On Tue, 2016-01-26 at 18:31 +0100, Thomas Gleixner wrote: > On Thu, 21 Jan 2016, Zhao Qiang wrote: > > > 127 is the theoretical up boundary of QEIC number, > > in fact there only be 44 qe_ic_info now. > > add check to overflow for qe_ic_info > > How do you trigger that overflow? The above does no

Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

2016-01-26 Thread Thomas Gleixner
On Thu, 21 Jan 2016, Zhao Qiang wrote: > 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info How do you trigger that overflow? The above does not explain WHY we need these checks. > diff --git a/drivers/soc/fsl/qe/q

Re: [PATCH] qe_ic: fix a buffer overflow error and add check elsewhere

2016-01-22 Thread Leo Li
On Thu, Jan 21, 2016 at 9:06 AM, Zhao Qiang wrote: > 127 is the theoretical up boundary of QEIC number, > in fact there only be 44 qe_ic_info now. > add check to overflow for qe_ic_info > > Signed-off-by: Zhao Qiang Acked-by: Li Yang Regards, Leo ___