Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-11 Thread Vladimir Murzin
On Thu, Sep 12, 2013 at 02:18:37AM +0100, Matt Evans wrote: > Hi Ben, Vladimir, > > > *dusts off very thick PPC cobwebs* Sorry for the delay as I'm travelling, > didn't get to this until now. > > On 02/09/2013, at 9:45 PM, Benjamin Herrenschmidt wrote: > > > On Mon, 2013-09-02 at 19:48 +0200,

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-11 Thread Matt Evans
Hi Ben, Vladimir, *dusts off very thick PPC cobwebs* Sorry for the delay as I'm travelling, didn't get to this until now. On 02/09/2013, at 9:45 PM, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-02 at 19:48 +0200, Vladimir Murzin wrote: >> Ping >> >> On Wed, Aug 28, 2013 at 02:49:52AM +040

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-11 Thread Vladimir Murzin
On Wed, Sep 04, 2013 at 09:04:04AM +0200, Daniel Borkmann wrote: > On 09/03/2013 10:52 PM, Daniel Borkmann wrote: > > On 09/03/2013 09:58 PM, Vladimir Murzin wrote: > [...] > >>> Do you have a test case/suite by any chance ? > >>> > >>> Ben. > >>> > >> > >> Hi Ben! > >> > >> Thanks for your feedbac

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-04 Thread Daniel Borkmann
On 09/03/2013 10:52 PM, Daniel Borkmann wrote: On 09/03/2013 09:58 PM, Vladimir Murzin wrote: [...] Do you have a test case/suite by any chance ? Ben. Hi Ben! Thanks for your feedback. This patch is only compile tested. I have no real hardware, but I'll probably bring up qemu ppc64 till e

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-03 Thread Daniel Borkmann
On 09/03/2013 09:58 PM, Vladimir Murzin wrote: On Tue, Sep 03, 2013 at 06:45:50AM +1000, Benjamin Herrenschmidt wrote: On Mon, 2013-09-02 at 19:48 +0200, Vladimir Murzin wrote: Ping On Wed, Aug 28, 2013 at 02:49:52AM +0400, Vladimir Murzin wrote: commit b6069a9570 (filter: add MOD operation)

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-03 Thread Vladimir Murzin
On Tue, Sep 03, 2013 at 06:45:50AM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2013-09-02 at 19:48 +0200, Vladimir Murzin wrote: > > Ping > > > > On Wed, Aug 28, 2013 at 02:49:52AM +0400, Vladimir Murzin wrote: > > > commit b6069a9570 (filter: add MOD operation) added generic > > > support for

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-02 Thread Benjamin Herrenschmidt
On Mon, 2013-09-02 at 19:48 +0200, Vladimir Murzin wrote: > Ping > > On Wed, Aug 28, 2013 at 02:49:52AM +0400, Vladimir Murzin wrote: > > commit b6069a9570 (filter: add MOD operation) added generic > > support for modulus operation in BPF. > > Sorry, nobody got a chance to review that yet. Unfortu

Re: [PATCH] ppc: bpf_jit: support MOD operation

2013-09-02 Thread Vladimir Murzin
Ping On Wed, Aug 28, 2013 at 02:49:52AM +0400, Vladimir Murzin wrote: > commit b6069a9570 (filter: add MOD operation) added generic > support for modulus operation in BPF. > > This patch brings JIT support for PPC64 > > Signed-off-by: Vladimir Murzin > --- > arch/powerpc/net/bpf_jit_comp.c | 2