Re: [PATCH] powerpc: check_and_cede_processor never cedes

2012-06-28 Thread Benjamin Herrenschmidt
On Thu, 2012-06-28 at 09:13 +1000, Anton Blanchard wrote: > Hi, > > > I'd rather add a helper, something like lazy_irq_pending() > > and hide the actual check for the bits in irq_happened, in > > case we change the scheme again. > > Good idea. Look ok? > > -- > > Commit f948501b36c6 ("Make hard

Re: [PATCH] powerpc: check_and_cede_processor never cedes

2012-06-27 Thread Benjamin Herrenschmidt
On Thu, 2012-06-28 at 08:45 +1000, Anton Blanchard wrote: > hard_irq_disable(); > - if (get_paca()->irq_happened == 0) > + if (get_paca()->irq_happened == PACA_IRQ_HARD_DIS) > cede_processor(); I'd rather add a helper, something like lazy_irq_pending() and hide the actu