Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-28 Thread David Gibson
On Sat, Sep 27, 2008 at 03:35:27AM +0400, Ilya Yanok wrote: > Hello David, > > David Gibson wrote: >> I don't see any reason to have a separate set of config options for 32 >> and 64-bit. Just make the once choice, but only have the individual >> pagesize options enabled on machines that support t

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-26 Thread Ilya Yanok
Hello Benjamin, Benjamin Herrenschmidt wrote: [snip] diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_booke.h index fce2df9..4f802df 100644 --- a/arch/powerpc/kernel/head_booke.h +++ b/arch/powerpc/kernel/head_booke.h @@ -20,7 +20,9 @@ beq 1f;

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-26 Thread Ilya Yanok
Hello David, David Gibson wrote: I don't see any reason to have a separate set of config options for 32 and 64-bit. Just make the once choice, but only have the individual pagesize options enabled on machines that support them. Well. I can see some. First, on PPC64 kernel emulates 64K page

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-13 Thread Josh Boyer
On Sat, 13 Sep 2008 10:49:13 -0700 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Thu, 2008-09-11 at 09:57 -0700, prodyut hazarika wrote: > > > You should mention an example of dedicated cases (eg. RAID). > > I think this help should mention that for page size 256KB, you will > > need to

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-13 Thread Benjamin Herrenschmidt
On Thu, 2008-09-11 at 09:57 -0700, prodyut hazarika wrote: > You should mention an example of dedicated cases (eg. RAID). > I think this help should mention that for page size 256KB, you will > need to have a special version of binutils, since the ELF standard > mentions page sizes only upto 64KB.

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-13 Thread Benjamin Herrenschmidt
> [snip] > > diff --git a/arch/powerpc/kernel/head_booke.h > > b/arch/powerpc/kernel/head_booke.h > > index fce2df9..4f802df 100644 > > --- a/arch/powerpc/kernel/head_booke.h > > +++ b/arch/powerpc/kernel/head_booke.h > > @@ -20,7 +20,9 @@ > > beq 1f;

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread David Gibson
On Thu, Sep 11, 2008 at 01:53:06AM +0400, Ilya Yanok wrote: > This patch adds support for page sizes bigger than 4KB (16KB/64KB/256KB) on > PPC 44x. [snip] > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index 587da5e..ca93157 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/K

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Josh Boyer
On Fri, 12 Sep 2008 03:38:39 +0400 Ilya Yanok <[EMAIL PROTECTED]> wrote: > Hello Josh, > > Josh Boyer wrote: > > Ok, but not everyone does. And I think setting the page size to this > > should be harder, maybe even dependent upon CONFIG_BROKEN. > > > > Well, we are violating ELF standard her

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Ilya Yanok
Hello Josh, Josh Boyer wrote: Ok, but not everyone does. And I think setting the page size to this should be harder, maybe even dependent upon CONFIG_BROKEN. Well, we are violating ELF standard here... CONFIG_BROKEN seems to be adequate for me. I need to look over the patch a bit more,

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Ilya Yanok
Hi, prodyut hazarika wrote: In file arch/powerpc/mm/pgtable_32.c, we have: #ifdef CONFIG_PTE_64BIT /* 44x uses an 8kB pgdir because it has 8-byte Linux PTEs. */ #define PGDIR_ORDER 1 #else #define PGDIR_ORDER 0 #endif pgd_t *pgd_alloc(struct mm_struct *mm) { pgd_t *ret;

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread prodyut hazarika
>/* > * Create WS1. This is the faulting address (EPN), > * page size, and valid flag. > */ > - li r11,PPC44x_TLB_VALID | PPC44x_TLB_4K > + li r11,PPC44x_TLB_VALID | PPC44x_TLBE_SIZE >rlwimi r10,r11,0,20,31 /* Insert val

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Ilya Yanok
Hi, prodyut hazarika wrote: Also, it would be great if you could point me what changes are necessary to recompile the binutils. I would like to test the 256KB changes on my Canyonlands board. I have got 16KB/64KB working. I think this should be enough: --- binutils-2.16.1/ld/emulparams/elf

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Josh Boyer
On Thu, Sep 11, 2008 at 10:15:07PM +0400, Yuri Tikhonov wrote: >> I think this help should mention that for page size 256KB, you will >> need to have a special version of binutils, since the ELF standard >> mentions page sizes only upto 64KB. > > Right. We use ELDK-4.2 for compiling applications to

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread prodyut hazarika
> > Any comments on the issues mentioned in introductory message? > I am reviewing the changes more thoroughly. I will give additional comments within the next 2-3 days. I am working on putting similar support for 405EX (Kilauea board), but having some issues. I will post the patch after I am done

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread prodyut hazarika
> > I think you missed first '-' on the first line. > I was not too careful :-) >> I think these 44x specific defines should go to asm/mmu-44x.h since I >> > > Agreed. > It would be great to have user-friendly names. Also moving to the mmu-4xx specific header files hides the changes to 4xx files.

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread Ilya Yanok
Hi, prodyut hazarika wrote: >> +choice >> + prompt "Page size" >> + depends on 44x && PPC32 >> + default PPC32_4K_PAGES >> + help >> + The PAGE_SIZE definition. Increasing the page size may >> + improve the system performance in some dedicated cases. >> +

Re: [PATCH] powerpc: add support for PAGE_SIZEs greater than 4KB for

2008-09-11 Thread prodyut hazarika
I was planning to post a similar patch. Good that you already posted it :-) I will try to finish off similar patch for 40x processors. > > +choice > + prompt "Page size" > + depends on 44x && PPC32 > + default PPC32_4K_PAGES > + help > + The PAGE_SIZE definition. In