Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Julian Vetter
On 1/28/25 15:16, Christophe Leroy wrote: Le 28/01/2025 à 14:57, Julian Vetter a écrit : Remove the eieio() calls in _memcpy_fromio, to bring its implementation closer to the one from lib/iomem_copy.c. These eieio() calls don't seem to be necessary, because the _memcpy_toio completely omits th

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Arnd Bergmann
On Tue, Jan 28, 2025, at 16:34, Christophe Leroy wrote: > Le 28/01/2025 à 16:24, Christophe Leroy a écrit : >> Le 28/01/2025 à 16:07, Julian Vetter a écrit : >>> With 'ppc' I was refering to 'include/asm-ppc/io.h'. But you're right, >>> when going back a bit, in the 'include/asm-powerpc/io.h' there

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 16:24, Christophe Leroy a écrit : Le 28/01/2025 à 16:07, Julian Vetter a écrit : [Vous ne recevez pas souvent de courriers de jul...@outer-limits.org. Découvrez pourquoi ceci est important à https://aka.ms/ LearnAboutSenderIdentification ] On 1/28/25 15:16, Christophe Ler

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 16:07, Julian Vetter a écrit : [Vous ne recevez pas souvent de courriers de jul...@outer-limits.org. Découvrez pourquoi ceci est important à https://aka.ms/ LearnAboutSenderIdentification ] On 1/28/25 15:16, Christophe Leroy wrote: Le 28/01/2025 à 14:57, Julian Vetter a é

Re: [PATCH] powerpc: Remove eieio in _memcpy_fromio

2025-01-28 Thread Christophe Leroy
Le 28/01/2025 à 14:57, Julian Vetter a écrit : Remove the eieio() calls in _memcpy_fromio, to bring its implementation closer to the one from lib/iomem_copy.c. These eieio() calls don't seem to be necessary, because the _memcpy_toio completely omits them. Also the legacy code from ppc was not