Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-09 Thread Matt Sealey
Segher Boessenkool wrote: >> Would you guys rather we shipped a boot script that ran the OS, fixed >> all these issues in-place in-firmware, so Linux did not have to have >> these >> workarounds, > > Sure, if you can do that, that would be great. Right, so don't accept that keyboard fix, and we

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-09 Thread Segher Boessenkool
>> That's hardly the only reason. But yeah, that's one way to >> implement the workaround, but _we_ (the Linux community) cannot >> do it like that (easily) for all users. > > But you're the guy who told us our firmware sucks and we should fix our > firmware Yes, and? You _should_ fix your firmw

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-07 Thread Matt Sealey
Okay, you don't need to be an experienced Open Firmware developer. In fact I know we have had experienced Open Firmware developers who have said that our firmware sucks (some comment about "shitty German engineering", I really did quit caring after that point) because they could not run probe-all

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-07 Thread Matt Sealey
Segher Boessenkool wrote: > > That's hardly the only reason. But yeah, that's one way to > implement the workaround, but _we_ (the Linux community) cannot > do it like that (easily) for all users. But you're the guy who told us our firmware sucks and we should fix our firmware rather than clutt

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-06 Thread Alan Curry
I'm almost sorry I spoke up... Matt Sealey writes the following: > >Okay before you add to the nvramrc you also need to add probe-all to build the >device tree first; I assumed this was common knowledge. Maybe for experienced OpenFirmware developers; this is the first time I've had to touch the s

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-06 Thread Segher Boessenkool
> 2) The fix was in the wrong place anyway, if it was going to be done > anywhere > at all it needs to be in > arch/powerpc/kernel/prom_init.c:fixup_device_tree_chrp() > like the ISA ranges breakage (which is on Briq) and IDE IRQ > misnumbering fix. > Not the keyboard platform driver. Yeah. In

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-06 Thread Matt Sealey
Okay before you add to the nvramrc you also need to add probe-all to build the device tree first; I assumed this was common knowledge. probe-all " /pci/isa/8042" find-device " 8042" encode-string device-type install-console banner That should do it. Without probe-all/install-console/banner in the

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-06 Thread Segher Boessenkool
>> You don't need to patch Linux at all. In fact for silly things like >> this >> I would recommend against it :) > > If the workaround doesn't go into the kernel, everybody with affected > hardware has to individually find out about the bug (probably by > experiencing > an annoying keyboardless

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-01 Thread Alan Curry
Matt Sealey writes the following: > >Yeah please do a fixup for the boot wrapper. > >Or, if you have trouble, go into the firmware and type "nvedit", add >these lines; > >" /isa/8042" find-device >" 8042" encode-string device-type > >(then ctrl-c to exit and nvstore to run it on next reboot. Try it

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-01 Thread Matt Sealey
Just so you guys have it all in one pretty little package, these will remove the need for the Pegasos IDE and ISA fixups in the prom_init.c too. s" /[EMAIL PROTECTED]/[EMAIL PROTECTED],1" find-device d# 14 encode-int 0 encode-int d# 15 encode-int 0 encode-int encode+ encode+ encode+ s" interrupts

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-08-01 Thread Matt Sealey
Yeah please do a fixup for the boot wrapper. Or, if you have trouble, go into the firmware and type "nvedit", add these lines; " /isa/8042" find-device " 8042" encode-string device-type (then ctrl-c to exit and nvstore to run it on next reboot. Try it without the patch first, on the firmware con

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-31 Thread Segher Boessenkool
> As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse > controller > on the PegasosPPC. This is because of a feature/bug in the OF device > tree: > the "device_type" attribute is an empty string instead of "8042" as the > kernel expects. This patch (against 2.6.22.1) adds a seconda

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-27 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 21:22 -0700, Andrew Morton wrote: > > > Merged a fixed version: > > > > f5d834fc34e61f1a40435981062000e5d2b2baa8 > > > > (In linus tree as of now) > > I hope so. Alan's patch looks rather different from what you have > now: > fall back to of_find_node_by_name() if of_find

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-26 Thread Alan Curry
Andrew Morton writes the following: >> > >> > Did this get merged, or otherwise fixed? Even though the code in there has >> > changed quite a bit, it looks to my untrained eye like the fix is still >> > applicable? >> >> Merged a fixed version: >> >> f5d834fc34e61f1a40435981062000e5d2b2baa8 >>

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-26 Thread Andrew Morton
On Fri, 27 Jul 2007 13:00:21 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Thu, 2007-07-26 at 18:48 -0700, Andrew Morton wrote: > > On Wed, 25 Jul 2007 17:12:45 +1000 Benjamin Herrenschmidt <[EMAIL > > PROTECTED]> wrote: > > > > > On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wro

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-26 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 18:48 -0700, Andrew Morton wrote: > On Wed, 25 Jul 2007 17:12:45 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> > wrote: > > > On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > > > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse > > > controller >

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-26 Thread Andrew Morton
On Wed, 25 Jul 2007 17:12:45 +1000 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse > > controller > > on the PegasosPPC. This is because of a feature/bug in the OF devi

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-25 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller > on the PegasosPPC. This is because of a feature/bug in the OF device tree: > the "device_type" attribute is an empty string instead of "8042" as the > kernel expect

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Alan Curry
Benjamin Herrenschmidt writes the following: > >Doesn't it have something in "compatible" instead ? that would be the >way to go. > Assuming that would be represented as a file named "compatible" in the directory /proc/device-tree/*/*/[EMAIL PROTECTED] ... no, it doesn't have one of those. For th

Re: [PATCH] powerpc: Pegasos keyboard detection

2007-07-24 Thread Benjamin Herrenschmidt
On Tue, 2007-07-24 at 21:28 -0400, Alan Curry wrote: > As of 2.6.22 the kernel doesn't recognize the i8042 keyboard/mouse controller > on the PegasosPPC. This is because of a feature/bug in the OF device tree: > the "device_type" attribute is an empty string instead of "8042" as the > kernel expect