Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT

2010-10-06 Thread Kumar Gala
On Sep 24, 2010, at 11:44 AM, Paul Gortmaker wrote: >> >> From d48ebb58b8214f9faec775a5e06902f638f165cf Mon Sep 17 00:00:00 2001 > From: Tiejun Chen > Date: Tue, 21 Sep 2010 19:31:31 +0800 > Subject: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for > PTE_64BIT > > There exis

Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT

2010-09-24 Thread Paul Gortmaker
[Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT] On 24/09/2010 (Fri 07:59) Benjamin Herrenschmidt wrote: > On Thu, 2010-09-23 at 15:33 -0500, Scott Wood wrote: > > I don't see a generic accessor that can test PTE flags for user > > access

Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT

2010-09-23 Thread Benjamin Herrenschmidt
On Thu, 2010-09-23 at 15:33 -0500, Scott Wood wrote: > I don't see a generic accessor that can test PTE flags for user > access -- in the absence of one, I guess we need an ifdef here. Or at > least put in a comment so anyone who adds a userspace use knows they > need to fix it. We could make up

Re: [PATCH] powerpc: Fix invalid page flags in create TLB CAM path for PTE_64BIT

2010-09-23 Thread Scott Wood
On Thu, 23 Sep 2010 16:10:15 -0400 Paul Gortmaker wrote: > So the possibility exists to wrongly assign the user MAS3_U bits > to kernel (PAGE_KERNEL_X) address space via the following code fragment: > > if (flags & _PAGE_USER) { >TLBCAM[index].MAS3 |= MAS3_UX | MAS3_UR; >