Re: [PATCH] powerpc: Add xmon function to dump 44x TLB

2007-11-16 Thread Benjamin Herrenschmidt
On Fri, 2007-11-16 at 17:09 +0100, Segher Boessenkool wrote: > >> +#ifdef CONFIG_44x > >> +static void dump_tlb_44x(void); > >> +#endif > > > > No need to #ifdef this... > > > >> +#ifdef CONFIG_44x > >> +static void dump_tlb_44x(void) > >> +{ > > > > ...or this. > > Erm actually, that last one wo

Re: [PATCH] powerpc: Add xmon function to dump 44x TLB

2007-11-16 Thread Benjamin Herrenschmidt
On Fri, 2007-11-16 at 16:54 +0100, Segher Boessenkool wrote: > > +#ifdef CONFIG_44x > > +static void dump_tlb_44x(void); > > +#endif > > No need to #ifdef this... > > > +#ifdef CONFIG_44x > > +static void dump_tlb_44x(void) > > +{ > > ...or this. I don't want to require binutils to understand

Re: [PATCH] powerpc: Add xmon function to dump 44x TLB

2007-11-16 Thread Segher Boessenkool
> +#ifdef CONFIG_44x > +static void dump_tlb_44x(void); > +#endif No need to #ifdef this... > +#ifdef CONFIG_44x > +static void dump_tlb_44x(void) > +{ ...or this. Segher ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailm

Re: [PATCH] powerpc: Add xmon function to dump 44x TLB

2007-11-16 Thread Segher Boessenkool
>> +#ifdef CONFIG_44x >> +static void dump_tlb_44x(void); >> +#endif > > No need to #ifdef this... > >> +#ifdef CONFIG_44x >> +static void dump_tlb_44x(void) >> +{ > > ...or this. Erm actually, that last one would give you a compiler warning ("function defined but not used"), unless you convert th