Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Madhavan Srinivasan
On Monday 14 August 2017 09:00 AM, Michael Ellerman wrote: Dan Carpenter writes: There is a typo so we call unlock instead of lock. Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support") Signed-off-by: Dan Carpenter --- I also don't understand how the &nest_imc_refc[node_id].lock w

Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Madhavan Srinivasan
On Saturday 12 August 2017 01:35 AM, Dan Carpenter wrote: There is a typo so we call unlock instead of lock. Reviewed-by: Madhavan Srinivasan nest_imc_refc used to maintain list of perf sessions thats using the nest units currently. This is needed in turning off nest engine microcode when n

Re: [PATCH] powerpc/perf: double unlock bug in imc_common_cpuhp_mem_free()

2017-08-13 Thread Michael Ellerman
Dan Carpenter writes: > There is a typo so we call unlock instead of lock. > > Fixes: 885dcd709ba9 ("powerpc/perf: Add nest IMC PMU support") > Signed-off-by: Dan Carpenter > --- > I also don't understand how the &nest_imc_refc[node_id].lock works. Why > can't we use ref->lock everywhere? They