Re: [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better

2011-09-13 Thread Scott Wood
On 09/07/2011 11:20 AM, Tabi Timur-B04825 wrote: > The problem is that both offset and irq_index are being incremented in > the loop, and cascade_data->index is set to the sum of the two. > > Perhaps you meant this: > > err = fsl_msi_setup_hwirq(msi, dev, offset, j); That's not rig

Re: [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better

2011-09-07 Thread Tabi Timur-B04825
On Mon, Jan 17, 2011 at 2:25 PM, Scott Wood wrote: > +       for (irq_index = 0, i = 0; i < len / (2 * sizeof(u32)); i++) { > +               if (p[i * 2] % IRQS_PER_MSI_REG || > +                   p[i * 2 + 1] % IRQS_PER_MSI_REG) { > +                       printk(KERN_WARNING "%s: %s: msi avai

Re: [PATCH] powerpc/fsl_msi: Handle msi-available-ranges better

2011-03-15 Thread Kumar Gala
On Jan 17, 2011, at 2:25 PM, Scott Wood wrote: > Now handles multiple ranges, doesn't make assumptions about interrupt > specifier format, and doesn't claim interrupts that don't correspond to an > available range. > > Also has some better error checking. > > The device tree binding is updated