Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-25 Thread Gabriel Paubert
On Sat, Dec 22, 2018 at 05:04:51PM -0600, Segher Boessenkool wrote: > On Sat, Dec 22, 2018 at 08:37:28PM +0100, christophe leroy wrote: > > Le 22/12/2018 à 18:16, Segher Boessenkool a écrit : > > >On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: > > >> > > >>Usually, Guarded implie

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-23 Thread christophe leroy
Le 23/12/2018 à 10:31, Segher Boessenkool a écrit : On Sun, Dec 23, 2018 at 09:29:44AM +0100, Gabriel Paubert wrote: • The fetch access is to guarded storage and MSR[IR] = 1. That is architected, yes. You get an ISI if IR=1 and (N=1 or G=1). If IR=0, mappings don't apply. So in 4xx/oc

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-23 Thread Segher Boessenkool
On Sun, Dec 23, 2018 at 09:29:44AM +0100, Gabriel Paubert wrote: > • The fetch access is to guarded storage and MSR[IR] = 1. That is architected, yes. You get an ISI if IR=1 and (N=1 or G=1). Segher

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Segher Boessenkool
On Sat, Dec 22, 2018 at 08:37:28PM +0100, christophe leroy wrote: > Le 22/12/2018 à 18:16, Segher Boessenkool a écrit : > >On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: > >> > >>Usually, Guarded implies no exec (at least on 6xx and 8xx). > > > >Huh? What do you mean here? > >

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 18:16, Segher Boessenkool a écrit : On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: Usually, Guarded implies no exec (at least on 6xx and 8xx). Huh? What do you mean here? From the 885 Reference Manual: Address translation: the EA is translated by usi

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Segher Boessenkool
On Sat, Dec 22, 2018 at 02:08:02PM +0100, christophe leroy wrote: > > Usually, Guarded implies no exec (at least on 6xx and 8xx). Huh? What do you mean here? Segher

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Christian Lamparter
On Saturday, December 22, 2018 2:08:02 PM CET christophe leroy wrote: > > Le 22/12/2018 à 12:27, Christian Lamparter a écrit : > > On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: > >> > >> Le 22/12/2018 à 11:09, Christian Lamparter a écrit : > >>> This patch fixes a recent r

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 12:27, Christian Lamparter a écrit : On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: Le 22/12/2018 à 11:09, Christian Lamparter a écrit : This patch fixes a recent regression in ocm: ocm.c: In function ‘ocm_init_node’: ocm.c:182:18: error: invalid ope

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread Christian Lamparter
On Saturday, December 22, 2018 11:59:04 AM CET christophe leroy wrote: > > Le 22/12/2018 à 11:09, Christian Lamparter a écrit : > > This patch fixes a recent regression in ocm: > > > > ocm.c: In function ‘ocm_init_node’: > > ocm.c:182:18: error: invalid operands to binary | > > ocm.c:197:17: erro

Re: [PATCH] powerpc/4xx/ocm: fix compiler error

2018-12-22 Thread christophe leroy
Le 22/12/2018 à 11:09, Christian Lamparter a écrit : This patch fixes a recent regression in ocm: ocm.c: In function ‘ocm_init_node’: ocm.c:182:18: error: invalid operands to binary | ocm.c:197:17: error: invalid operands to binary | Fixes: 56f3c1413f5c ("powerpc/mm: properly set PAGE_KERNEL