Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Oliver O'Halloran
On Wed, Sep 8, 2021 at 8:02 AM Tyrel Datwyler wrote: > > On 9/7/21 1:59 AM, Xu Wang wrote: > > Device node iterators put the previous value of the index variable, > > so an explicit put causes a double put. > > > > Signed-off-by: Xu Wang > > --- > > drivers/pci/hotplug/pnv_php.c | 1 - > > 1 fil

Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Tyrel Datwyler
On 9/7/21 1:59 AM, Xu Wang wrote: > Device node iterators put the previous value of the index variable, > so an explicit put causes a double put. > > Signed-off-by: Xu Wang > --- > drivers/pci/hotplug/pnv_php.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/pci/hotplug/pnv_php.

Re: [PATCH] pci/hotplug/pnv-php: Remove probable double put

2021-09-07 Thread Bjorn Helgaas
Make your subject line follow the previous convention. Figure out if this is a "probable" or a real double put. If it's a real double put, we should fix it. If it's only "probable," that means we don't understand the problem yet. On Tue, Sep 07, 2021 at 08:59:46AM +, Xu Wang wrote: > Device