Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Dan Williams
On Thu, Mar 13, 2008 at 4:14 PM, Olof Johansson <[EMAIL PROTECTED]> wrote: > > Dummy descriptors that do nothing but cause an interrupt is the intent. > > Well, it'd be slightly more efficient to do add the interrupt attribute > to the last issued descriptor when it's known in advance. If the >

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Olof Johansson
On Thu, Mar 13, 2008 at 03:29:29PM -0700, Dan Williams wrote: > On Thu, Mar 13, 2008 at 12:54 PM, Olof Johansson <[EMAIL PROTECTED]> wrote: > > On Tue, Mar 11, 2008 at 10:04:11AM -0700, Dan Williams wrote: > > > > > I notice that the driver does not handle callbacks in its descriptor > > > cleanu

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Dan Williams
On Thu, Mar 13, 2008 at 12:54 PM, Olof Johansson <[EMAIL PROTECTED]> wrote: > On Tue, Mar 11, 2008 at 10:04:11AM -0700, Dan Williams wrote: > > > I notice that the driver does not handle callbacks in its descriptor > > cleanup path. This could be ok if your intent is only to support the > > net

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-13 Thread Olof Johansson
On Tue, Mar 11, 2008 at 10:04:11AM -0700, Dan Williams wrote: > I notice that the driver does not handle callbacks in its descriptor > cleanup path. This could be ok if your intent is only to support the > net_dma style polled operations, but this will not work for the > raid-offload async_tx cas

Re: [PATCH] pasemi_dma: Driver for PA Semi PWRficient on-chip DMAengine

2008-03-11 Thread Dan Williams
On Thu, 2008-03-06 at 16:39 -0700, Olof Johansson wrote: > pasemi_dma: Driver for PA Semi PWRficient on-chip DMA engine > > First cut at a dma copy offload driver for PA Semi PWRficient. It uses the > platform-specific functions to allocate channels, etc. > > Signed-off-by: Olof Johansson <[EM