On Tue, Dec 28, 2010 at 07:05:26PM +0300, Anton Vorontsov wrote:
> On Mon, Aug 30, 2010 at 11:49:08AM -0600, Grant Likely wrote:
> > On Mon, Aug 30, 2010 at 10:38 AM, David Brownell
> > wrote:
> > > Since I don't do OpenFirmware, let's hear from
> > > Grant on this one.
> >
> > Looks good to me.
On Mon, Aug 30, 2010 at 11:49:08AM -0600, Grant Likely wrote:
> On Mon, Aug 30, 2010 at 10:38 AM, David Brownell wrote:
> > Since I don't do OpenFirmware, let's hear from
> > Grant on this one.
>
> Looks good to me.
>
> Acked-by: Grant Likely
I wonder what happened with this patch?
Thanks,
-
On Mon, Aug 30, 2010 at 7:46 PM, Grant Likely wrote:
> On Mon, Aug 30, 2010 at 10:04 AM, Esben Haabendal
>> Hopefully, arm users will soon enjoy this driver/wrapper soon also.
>
> My hope is that even on ARM when the device tree is used I'll be able
> eliminate IRQs mapped to 0 (but I need to do a
On Mon, Aug 30, 2010 at 10:38 AM, David Brownell wrote:
> Since I don't do OpenFirmware, let's hear from
> Grant on this one.
Looks good to me.
Acked-by: Grant Likely
>
>
> ___
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lis
On Mon, Aug 30, 2010 at 10:04 AM, Esben Haabendal
wrote:
> On Mon, Aug 30, 2010 at 3:29 PM, Anton Vorontsov
> wrote:
>>> @@ -121,8 +136,14 @@ struct mmc_spi_platform_data
>>> *mmc_spi_get_pdata(struct spi_device *spi)
>>> if (gpio_is_valid(oms->gpios[WP_GPIO]))
>>> oms->p
Since I don't do OpenFirmware, let's hear from
Grant on this one.
___
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
> of_mmc_spi: add card detect irq support
>
> Signed-off-by: Esben Haabendal
Acked-by: Anton Vorontsov
Thanks!
> ---
> .../powerpc/dts-bindings/mmc-spi-slot.txt |9 ++-
> drivers/mmc/host/of_mmc_spi.c | 26 ++-
> 2 files changed, 32 ins
Hi
Comments below, and updated patch attached.
On Mon, Aug 30, 2010 at 3:29 PM, Anton Vorontsov wrote:
>>> +static int of_mmc_spi_init(struct device *dev,
>> + irqreturn_t (*irqhandler)(int, void *), void *mmc)
>> +{
>> + struct of_mmc_spi *oms = to_of_mmc_spi(dev)
Hello,
The patch looks mostly good. A few cosmetic issues down below.
On Mon, Aug 30, 2010 at 02:04:59PM +0200, Esben Haabendal wrote:
Please add some change log, a couple of sentences would work.
> Signed-off-by: Esben Haabendal
> ---
> drivers/mmc/host/of_mmc_spi.c | 25 +