Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
On Mon, Sep 14, 2009 at 2:03 AM, Wolfram Sang wrote: > Hi, > >> +             mpc5200_pic: interrupt-control...@500 { >> +                     // 5200 interrupts are encoded into two levels; > > Grant, maybe this comment could be dropped also for the in-kernel dts-files? I > think it is sufficentl

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
On Mon, Sep 14, 2009 at 8:32 AM, Heiko Schocher wrote: > Grant Likely wrote: >> On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher wrote: >>> +       soc5...@f000 { >>> +               #address-cells = <1>; >>> +               #size-cells = <1>; >>> +               compatible = "fsl,mpc5200-immr

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Heiko Schocher
Hello Grant, Grant Likely wrote: > Comments below. > > On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher wrote: >> - serial Console on PSC1 >> - 64MB SDRAM >> - MTD CFI Flash >> - Ethernet FEC >> - I2C with PCF8563 and Temp. Sensor ADM9240 >> - IDE support >> >> Signed-off-by: Heiko Schocher >> >

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Heiko Schocher
Hello Wolfram, Wolfram Sang wrote: > Hi, > >> +mpc5200_pic: interrupt-control...@500 { >> +// 5200 interrupts are encoded into two levels; > > Grant, maybe this comment could be dropped also for the in-kernel dts-files? I > think it is sufficently described in mpc

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Grant Likely
Hi Heiko. Comments below. On Mon, Sep 14, 2009 at 2:05 AM, Heiko Schocher wrote: > - serial Console on PSC1 > - 64MB SDRAM > - MTD CFI Flash > - Ethernet FEC > - I2C with PCF8563 and Temp. Sensor ADM9240 > - IDE support > > Signed-off-by: Heiko Schocher > >  arch/powerpc/boot/dts/mucmc52.dts  

Re: [PATCH] mpc5200: support for the MAN mpc5200 based board mucmc52

2009-09-14 Thread Wolfram Sang
Hi, > + mpc5200_pic: interrupt-control...@500 { > + // 5200 interrupts are encoded into two levels; Grant, maybe this comment could be dropped also for the in-kernel dts-files? I think it is sufficently described in mpc5200.txt. I could prepare a patch if you agree