Re: [PATCH] leds-gpio: Fix default state handling on OF platforms

2010-02-15 Thread Grant Likely
On Fri, Feb 5, 2010 at 1:54 PM, Anton Vorontsov wrote: > The driver wrongly sets default state for LEDs that don't specify > default-state property. > > Currently the driver handles default state this way: > > memset(&led, 0, sizeof(led)); > for_each_child_of_node(np, child) { >        state = of_

Re: [PATCH] leds-gpio: Fix default state handling on OF platforms

2010-02-08 Thread Anton Vorontsov
On Mon, Feb 08, 2010 at 01:04:55PM -0800, Andrew Morton wrote: > On Fri, 5 Feb 2010 23:54:37 +0300 > Anton Vorontsov wrote: > > > The driver wrongly sets default state for LEDs that don't specify > > default-state property. [...] > Does this actually happen in any 2.6.33 driver code? Well, the c

Re: [PATCH] leds-gpio: Fix default state handling on OF platforms

2010-02-08 Thread Andrew Morton
On Fri, 5 Feb 2010 23:54:37 +0300 Anton Vorontsov wrote: > The driver wrongly sets default state for LEDs that don't specify > default-state property. > > Currently the driver handles default state this way: > > memset(&led, 0, sizeof(led)); > for_each_child_of_node(np, child) { > state =