> Could we go forward with my initial patch, and then continue the work
> on this repeated START approach for future releases?
Then could you please send another version of your patch with the CodingStyle
issue removed and an updated description what this patch fixes and what still
needs to be res
Esben Haabendal wrote on 15/05/2009 14:52:28:
>
> Your new patch also does not work.
>
> Have you tested it?
sure, works fine. I haven't stressed it too much though.
>
> I already tried something very much what you sent here, I believe the
> only difference was that I named the "last" variable "
Your new patch also does not work.
Have you tested it?
I already tried something very much what you sent here, I believe the
only difference was that I named the "last" variable "stop". I also
tried several other aproaches, and none of them worked. I would
appreciate not to have to test all of t
Esben Haabendal wrote on 15/05/2009 12:18:39:
>
> I have now spent a few hours trying a lot of different paths to fix
> this approach, but I simply cannot find a way to get i2c read to work
> without a trailing STOP condition with this controller.
I found a bug which lets me remove the "fix" and
Hi
Your patch (and the small addition to mpc_i2c_start) does not work for me.
[ 35.765803] mpc_xfer()
[ 35.785480] writeccr 0
[ 35.785505] writeccr 80
[ 35.785523] mpc_xfer: 1 bytes to 2c:W - 1 of 2 messages
[ 35.798817] mpc_write addr=2c len=1 restart=0
[ 35.815327] writeccr f0
[ 3
Esben Haabendal wrote on 14/05/2009 12:17:48:
> On Thu, May 14, 2009 at 11:58 AM, Joakim Tjernlund
> wrote:
> >>
> >> The problem is that after the STOP condition, the following i2c_msg will be
> >> attempted with a repeated START, which according to specification will
> >> cause a MAL, which als
>
> Wolfram Sang wrote:
> > On Thu, May 14, 2009 at 10:10:03AM +0200, Esben Haabendal wrote:
> >
> >> This fixes MAL (arbitration lost) bug caused by illegal use of
> >> RSTA (repeated START) after STOP condition generated after last byte
> >> of reads.
> >>
> >>
> >
> > Could you elaborate a bit,
Wolfram Sang wrote:
On Thu, May 14, 2009 at 10:10:03AM +0200, Esben Haabendal wrote:
This fixes MAL (arbitration lost) bug caused by illegal use of
RSTA (repeated START) after STOP condition generated after last byte
of reads.
Could you elaborate a bit, please? Like an example when th
On Thu, May 14, 2009 at 10:10:03AM +0200, Esben Haabendal wrote:
> This fixes MAL (arbitration lost) bug caused by illegal use of
> RSTA (repeated START) after STOP condition generated after last byte
> of reads.
>
Could you elaborate a bit, please? Like an example when the original bug
occured (s
