Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2008-02-06 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-28 Thread Brandeburg, Jesse
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly

RE: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-28 Thread Benjamin Herrenschmidt
On Wed, 2007-11-28 at 10:47 -0800, Brandeburg, Jesse wrote: > > > The side effect is that I removed the assignments to the netdev > > fields mem_start, mem_end and base_addr, which are totally useless > > for PCI devices. > > also, concerning this, ifconfig shows the output of these variables, I

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-26 Thread Kok, Auke
Jeff Garzik wrote: > Benjamin Herrenschmidt wrote: >> The e1000 driver stores the content of the PCI resources into >> unsigned long's before ioremapping. This breaks on 32 bits >> platforms that support 64 bits MMIO resources such as ppc 44x. >> >> This fixes it by removing those temporary variabl

Re: [PATCH] e1000: Fix for 32 bits platforms with 64 bits resources

2007-11-23 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: > The e1000 driver stores the content of the PCI resources into > unsigned long's before ioremapping. This breaks on 32 bits > platforms that support 64 bits MMIO resources such as ppc 44x. > > This fixes it by removing those temporary variables and passing > directly