Re: [PATCH] cxl: remove redundant increment of hwirq

2015-02-01 Thread Michael Ellerman
On Sun, 2015-02-01 at 21:40 +, Colin King wrote: > From: Colin Ian King > > Recent commit 80fa93fce37d3490f > ("cxl: Name interrupts in /proc/interrupt") introduced a > redundant increment of hwirq which is not used or even > initialised at the point it is incremented. Detected by > cppcheck:

Re: [PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Ian Munsie
Acked-By: Ian Munsie ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] cxl: remove redundant increment of hwirq

2015-01-08 Thread Michael Neuling
On Thu, 2015-01-08 at 22:36 +, Colin King wrote: > From: Colin Ian King > > hwirq has not been initialized, however it is being incremented > and also not being referenced in a loop. This error was detected with > cppcheck: > > [drivers/misc/cxl/irq.c:439]: (error) Uninitialized variable: h