Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:50, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 02:34:07PM +0800, wanghai (M) wrote: 在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the err

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2020 at 02:34:07PM +0800, wanghai (M) wrote: > > 在 2020/6/3 14:14, Greg Kroah-Hartman 写道: > > On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: > > > 在 2020/6/3 1:20, Markus Elfring 写道: > > > > > Fix it by adding a call to kobject_put() in the error path of > > > > > kob

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Markus Elfring
> Please note that you are responding to someone that a lot of kernel > developers and maintainers have blacklisted as being very annoying I can understand that you can occasionally become annoyed. > and not helpful at all. I got the impression that some contributors (including you) found also

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Thanks for another completion of the exception handling. Would an o

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Greg Kroah-Hartman
On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: > > 在 2020/6/3 1:20, Markus Elfring 写道: > > > Fix it by adding a call to kobject_put() in the error path of > > > kobject_init_and_add(). > > Thanks for another completion of the exception handling. > > > > Would an other patch subject

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Michael Ellerman
"wanghai (M)" writes: > 在 2020/6/3 1:20, Markus Elfring 写道: >>> Fix it by adding a call to kobject_put() in the error path of >>> kobject_init_and_add(). >> Thanks for another completion of the exception handling. >> >> Would an other patch subject be a bit nicer? > Thanks for the guidance, I will

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Thanks for another completion of the exception handling. Would an other patch subject be a bit nicer? Thanks for the guidance, I will perfect this description and send a

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread Markus Elfring
> Fix it by adding a call to kobject_put() in the error path of > kobject_init_and_add(). Thanks for another completion of the exception handling. Would an other patch subject be a bit nicer? … > +++ b/drivers/misc/cxl/sysfs.c > @@ -624,7 +624,7 @@ static struct afu_config_record > *cxl_sysfs_