Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-26 Thread Christophe Leroy
Le 25/08/2022 à 20:08, Segher Boessenkool a écrit : > Hi! > > On Thu, Aug 25, 2022 at 04:00:52PM +0530, Naveen N. Rao wrote: >> This is causing a build issue on ppc64le with a new patch replacing use >> of unreachable() with __builtin_unreachable() in __WARN_FLAGS(): >> https://lore.kernel.org/l

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-26 Thread Christophe Leroy
Le 26/08/2022 à 09:02, Christophe Leroy a écrit : > > > Le 25/08/2022 à 20:08, Segher Boessenkool a écrit : >> Hi! >> >> On Thu, Aug 25, 2022 at 04:00:52PM +0530, Naveen N. Rao wrote: >>> This is causing a build issue on ppc64le with a new patch replacing use >>> of unreachable() with __builtin

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-26 Thread Christophe Leroy
Le 25/08/2022 à 20:08, Segher Boessenkool a écrit : > Hi! > > On Thu, Aug 25, 2022 at 04:00:52PM +0530, Naveen N. Rao wrote: >> This is causing a build issue on ppc64le with a new patch replacing use >> of unreachable() with __builtin_unreachable() in __WARN_FLAGS(): >> https://lore.kernel.org/l

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Segher Boessenkool
Hi! On Thu, Aug 25, 2022 at 04:00:52PM +0530, Naveen N. Rao wrote: > This is causing a build issue on ppc64le with a new patch replacing use > of unreachable() with __builtin_unreachable() in __WARN_FLAGS(): > https://lore.kernel.org/linuxppc-dev/20220808114908.240813-2...@linux.ibm.com/ What is

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Uros Bizjak
On Thu, Aug 25, 2022 at 12:30 PM Naveen N. Rao wrote: > > Uros Bizjak wrote: > > The workaround for 'asm goto' miscompilation introduces a compiler > > barrier quirk that inhibits many useful compiler optimizations. For > > example, __try_cmpxchg_user compiles to: > > > >11375: 41 8b 4d 00

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Christophe Leroy
Le 25/08/2022 à 12:30, Naveen N. Rao a écrit : > Uros Bizjak wrote: >> The workaround for 'asm goto' miscompilation introduces a compiler >> barrier quirk that inhibits many useful compiler optimizations. For >> example, __try_cmpxchg_user compiles to: >> >>    11375:    41 8b 4d 00 

Re: [PATCH] compiler-gcc.h: Remove ancient workaround for gcc PR 58670

2022-08-25 Thread Naveen N. Rao
Uros Bizjak wrote: The workaround for 'asm goto' miscompilation introduces a compiler barrier quirk that inhibits many useful compiler optimizations. For example, __try_cmpxchg_user compiles to: 11375: 41 8b 4d 00 mov0x0(%r13),%ecx 11379: 41 8b 02