Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-20 Thread Christoph Hellwig
On Tue, Aug 20, 2019 at 01:06:25PM +0200, Vlastimil Babka wrote: > > The whole point of copy_page is to copy exactly one page and it makes > > sense to assume that is aligned. A sane memcpy would use the same > > underlying primitives as well after checking they fit. So I think the > > prime issu

Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-20 Thread Vlastimil Babka
On 8/20/19 4:30 AM, Christoph Hellwig wrote: > On Mon, Aug 19, 2019 at 07:46:00PM +0200, David Sterba wrote: >> Another thing that is lost is the slub debugging support for all >> architectures, because get_zeroed_pages lacking the red zones and sanity >> checks. >> >> I find working with raw page

Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-19 Thread Christoph Hellwig
On Mon, Aug 19, 2019 at 07:46:00PM +0200, David Sterba wrote: > Another thing that is lost is the slub debugging support for all > architectures, because get_zeroed_pages lacking the red zones and sanity > checks. > > I find working with raw pages in this code a bit inconsistent with the > rest of

Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-19 Thread Christophe Leroy
Le 19/08/2019 à 19:46, David Sterba a écrit : On Sat, Aug 17, 2019 at 07:44:39AM +, Christophe Leroy wrote: Various notifications of type "BUG kmalloc-4096 () : Redzone overwritten" have been observed recently in various parts of the kernel. After some time, it has been made a relation wi

Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-19 Thread David Sterba
On Sat, Aug 17, 2019 at 07:44:39AM +, Christophe Leroy wrote: > Various notifications of type "BUG kmalloc-4096 () : Redzone > overwritten" have been observed recently in various parts of > the kernel. After some time, it has been made a relation with > the use of BTRFS filesystem. > > [ 22.

Re: [PATCH] btrfs: fix allocation of bitmap pages.

2019-08-17 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 69d2480456d1 btrfs: use copy_page for copying pages instead of memcpy. The bot has tested the following trees: v5.2.9, v4.19.67. v5.2.9: Build OK! v4.19.67: Failed to apply! Possi