Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-16 Thread Carl Love
On Fri, 2008-05-16 at 16:22 +0200, Arnd Bergmann wrote: > On Thursday 15 May 2008, Carl Love wrote: > > On Thu, 2008-05-15 at 17:39 +0200, Arnd Bergmann wrote: > > > > > > I noticed now that you are indexing arrays by SPU number. This is not > > > a good idea, because you make assumptions about t

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-16 Thread Arnd Bergmann
On Thursday 15 May 2008, Carl Love wrote: > On Thu, 2008-05-15 at 17:39 +0200, Arnd Bergmann wrote: > > > > I noticed now that you are indexing arrays by SPU number. This is not > > a good idea, because you make assumptions about the system that may > > not be true. Better pass around 'struct spu'

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-15 Thread Carl Love
On Thu, 2008-05-15 at 17:39 +0200, Arnd Bergmann wrote: > On Thursday 01 May 2008, Carl Love wrote: > > > Finally, this patch backs out the changes previously added to the > > oprofile generic code for handling the architecture specific > > ops.sync_start and ops.sync_stop that allowed the arch

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-15 Thread Arnd Bergmann
On Thursday 01 May 2008, Carl Love wrote: > Finally, this patch backs out the changes previously added to the > oprofile generic code for handling the architecture specific > ops.sync_start and ops.sync_stop that allowed the architecture > to skip the per CPU buffer creation. Thanks for your pa

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-02 Thread Maynard Johnson
Phil, When you have a chance, could you please take a look at the arch-independent pieces of the OProfile kernel driver that this patch touches? In short, this patch fixes a bug that I was responsible for in my original OProfile-Cell SPE port (argh! :-[ ) where I was improperly adding events

Re: [PATCH] Updated: Reworked Cell OProfile: SPU mutex lock fix

2008-05-01 Thread Maynard Johnson
Carl Love wrote: Sorry, looks like my mailer mangled the file. This is a reworked patch to fix the SPU data storage. Currently, the SPU escape sequences and program counter data is being added directly into the kernel buffer without holding the buffer_mutex lock. This patch changes how the