On Tue, Apr 01, 2008 at 03:12:20PM +0200, Jens Osterkamp wrote:
>
> Hi,
>
> rtas_flash was broken since 2.6.24-rc5. This patch fixes it.
> I think this is a good bugfix candidate for 2.6.25.
NACK. driver should not poke into the internal count member. Just
provide your own inclusion with a new
Paul Mackerras wrote:
> Nathan Lynch writes:
>
> > I think this is better... the way these files are used is lame, but
> > this should preserve the existing behavior. I haven't yet tested
> > this, can you?
>
> Looks OK -- can I have a proper patch description and a signed-off-by
> line for this
Nathan Lynch writes:
> I think this is better... the way these files are used is lame, but
> this should preserve the existing behavior. I haven't yet tested
> this, can you?
Looks OK -- can I have a proper patch description and a signed-off-by
line for this please?
Paul.
__
On Tuesday 01 April 2008, Nathan Lynch wrote:
> Nathan Lynch wrote:
> >
> > One could argue that the real problem is using the proc_dir_entry's
> > reference count to enforce exclusive open.
>
>
> I think this is better... the way these files are used is lame, but
> this should preserve the exis
On Tuesday 01 April 2008, Nathan Lynch wrote:
> Jens Osterkamp wrote:
> >
> > Handling of the proc_dir_entry->count has being changed in 2.6.24-rc5.
>
> Do you know which commit caused the change?
Yes, we bisected it to the following commit :
commit 5a622f2d0f86b316b07b55a4866ecb5518dd1cf7
Auth
Nathan Lynch wrote:
>
> One could argue that the real problem is using the proc_dir_entry's
> reference count to enforce exclusive open.
I think this is better... the way these files are used is lame, but
this should preserve the existing behavior. I haven't yet tested
this, can you?
diff --g
Jens Osterkamp wrote:
>
> Handling of the proc_dir_entry->count has being changed in 2.6.24-rc5.
Do you know which commit caused the change?
> After this change the default value for pde->count is 1 and not 0 as it
> was in earlier kernels. Therefore, if we want to check wether our procfs
> fil
