Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Josh Boyer
On Tue, 8 Jan 2008 23:13:14 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: [snip mostly valid stuff] > Yes, it's common sense and politeness to keep Signed-off-by lines > intact (and the order of these lines), but it's not strict > requirement. "Based on the patch from ..." is the equivalent of

Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Anton Vorontsov
On Tue, Jan 08, 2008 at 01:02:51PM -0600, Josh Boyer wrote: > On Tue, 08 Jan 2008 13:30:00 -0500 > Sean MacLennan <[EMAIL PROTECTED]> wrote: > > > Ok, here is the ad7414 only. taco-dtm is no more! > > Cool. Couple more things. > > 1) This should go through the hwmon maintainer. Send it to him.

Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Stefan Roese
On Tuesday 08 January 2008, Josh Boyer wrote: > On Tue, 08 Jan 2008 13:30:00 -0500 > > Sean MacLennan <[EMAIL PROTECTED]> wrote: > > Ok, here is the ad7414 only. taco-dtm is no more! > > Cool. Couple more things. > > 1) This should go through the hwmon maintainer. Send it to him. > (CC'ing this l

Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Josh Boyer
On Tue, 08 Jan 2008 13:30:00 -0500 Sean MacLennan <[EMAIL PROTECTED]> wrote: > Ok, here is the ad7414 only. taco-dtm is no more! Cool. Couple more things. 1) This should go through the hwmon maintainer. Send it to him. (CC'ing this list is of course fine.) 2) You always need the Signed-off-by

Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Sean MacLennan
Ok, here is the ad7414 only. taco-dtm is no more! Cheers, Sean diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index a0445be..f14972a 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -57,6 +57,16 @@ config SENSORS_ABITUGURU3 This driver can also be built a

Re: [PATCH] Hwmon for Taco

2008-01-08 Thread Sean MacLennan
Grant Likely wrote: > This is *very* board specific and not very complex a driver. It > should probably live with the platform code somewhere in > arch/powerpc/platforms. You can use the machine_device_initcall() > hook to kick off the thread. > Doh, this is why I post to this list. The platfo

Re: [PATCH] Hwmon for Taco

2008-01-07 Thread Grant Likely
On 1/7/08, Sean MacLennan <[EMAIL PROTECTED]> wrote: > diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig > index a0445be..1f89186 100644 > --- a/drivers/hwmon/Kconfig > +++ b/drivers/hwmon/Kconfig > @@ -57,6 +57,16 @@ config SENSORS_ABITUGURU3 >This driver can also be built as a mo

Re: [PATCH] Hwmon for Taco

2008-01-07 Thread Sean MacLennan
Benjamin Herrenschmidt wrote: > That should be in the device-tree... > > Cheers, > Ben. > > Now in the device tree. The name of the file has changed. Cheers, Sean diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index a0445be..1f89186 100644 --- a/drivers/hwmon/Kconfig +++ b/dri

Re: [PATCH] Hwmon for Taco

2008-01-05 Thread Sean MacLennan
Benjamin Herrenschmidt wrote: >> +module_exit(ad7414_exit); >> --- /dev/null2005-11-20 22:22:37.0 -0500 >> +++ drivers/hwmon/taco-dtm.c 2008-01-05 00:06:21.0 -0500 >> @@ -0,0 +1,78 @@ >> +/* >> + * drivers/hwmon/taco-dtm.c >> + * >> + * Overview: On the Taco, the fpga cont

Re: [PATCH] Hwmon for Taco

2008-01-04 Thread Benjamin Herrenschmidt
> +module_exit(ad7414_exit); > --- /dev/null 2005-11-20 22:22:37.0 -0500 > +++ drivers/hwmon/taco-dtm.c 2008-01-05 00:06:21.0 -0500 > @@ -0,0 +1,78 @@ > +/* > + * drivers/hwmon/taco-dtm.c > + * > + * Overview: On the Taco, the fpga controls the fan. This provides > + * the temp