Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Grant Likely
On 10/8/07, Arnd Bergmann <[EMAIL PROTECTED]> wrote: > On Monday 08 October 2007, Grant Likely wrote: > > Oh, and cell does too. Geoff, does cell support really need to do this: > > (in cell/setup.c and celleb/setup.c). > > if (ROOT_DEV == 0) { > > printk("No ramdisk, default root is /dev/hda2\n");

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Arnd Bergmann
On Monday 08 October 2007, Grant Likely wrote: > Oh, and cell does too.  Geoff, does cell support really need to do this: > (in cell/setup.c and celleb/setup.c). > if (ROOT_DEV == 0) { > printk("No ramdisk, default root is /dev/hda2\n"); > ROOT_DEV = Root_HDA

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 03:42:21PM -0500, Linas Vepstas wrote: > On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: > > > > On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > > > > >>> I can't see a good reason for eval board platform code to mess with > > >>> the > > >>> ROOT_DEV value i

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Grant Likely
On 10/8/07, Grant Likely <[EMAIL PROTECTED]> wrote: > On 10/8/07, Kumar Gala <[EMAIL PROTECTED]> wrote: > > > > On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: > > > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > > > I can't see a good reason for eval board platform code to mess with > > > the

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Benjamin Herrenschmidt
On Mon, 2007-10-08 at 14:41 -0500, Kumar Gala wrote: > > Powermac and pseries also do this weirdness. Should it be removed > > from there too? > > We need benh to make a comment about powermac. > > I think its ok to remove everywhere but we should see if he has any > issue. PowerMac has some

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Linas Vepstas
On Mon, Oct 08, 2007 at 02:41:54PM -0500, Kumar Gala wrote: > > On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > > >>> I can't see a good reason for eval board platform code to mess with > >>> the > >>> ROOT_DEV value instead of using the default behaviour (so I'm > > > > Powermac and pseries

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Kumar Gala
On Oct 8, 2007, at 2:03 PM, Grant Likely wrote: > On 10/8/07, Kumar Gala <[EMAIL PROTECTED]> wrote: >> >> On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: >> >>> From: Grant Likely <[EMAIL PROTECTED]> >>> >>> I can't see a good reason for eval board platform code to mess with >>> the >>> ROOT_DEV

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Grant Likely
On 10/8/07, Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: > > > From: Grant Likely <[EMAIL PROTECTED]> > > > > I can't see a good reason for eval board platform code to mess with > > the > > ROOT_DEV value instead of using the default behaviour (so I'm w

Re: [PATCH] Eval boards should not need to mess with ROOT_DEV

2007-10-08 Thread Kumar Gala
On Oct 8, 2007, at 10:12 AM, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > I can't see a good reason for eval board platform code to mess with > the > ROOT_DEV value instead of using the default behaviour (so I'm writing > this patch to see if anyone will clue me in). > > Sig