Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-19 Thread Josh Boyer
On Fri, 18 Jul 2008 15:31:33 -0700 (PDT) Victor Gallardo <[EMAIL PROTECTED]> wrote: > > > From what I can tell, you don't even need this patch or the defconfig. > > Nothing differs at this point from Glacier other than the DTS. Since > > U-Boot is your loader, it should be able to pass the diffe

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-18 Thread Stefan Roese
On Wednesday 16 July 2008, [EMAIL PROTECTED] wrote: > From: Victor Gallardo <[EMAIL PROTECTED]> > > ppc4xx: Add AMCC Arches 460GT eval board support > > Signed-off-by: Victor Gallardo <[EMAIL PROTECTED]> Please put a brief description of Arches in the patch description. Best regards, Stefan _

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Segher Boessenkool
Shouldn't it be enough to have a common compatible value in each of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the specific type unless you need to do something special? This is bad for the same reason that "amcc,44x-" compatible values are bad in device nodes.  The definitio

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Segher Boessenkool
And then you don't need this file at all. Just add a "amcc,canyonlands" string to your root node compatible property. No! Don't do this because it is not true! If the board actually _is_ compatible to the canyonlands board (it only _adds_ stuff, doesn't change things or takes away things), i

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Segher Boessenkool
Shouldn't it be enough to have a common compatible value in each of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the specific type unless you need to do something special? This is bad for the same reason that "amcc,44x-" compatible values are bad in device nodes. The definitio

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Josh Boyer
On Thu, 2008-07-17 at 00:58 +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2008, Grant Likely wrote: > > > > > Shouldn't it be enough to have a common compatible value in each > > > of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the > > > specific type unless you need to do s

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2008, Grant Likely wrote: > > > Shouldn't it be enough to have a common compatible value in each > > of these boards, e.g. "amcc,generic-ppc44x" and then just ignore the > > specific type unless you need to do something special? > > This is bad for the same reason that "amcc,

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Grant Likely
On Wed, Jul 16, 2008 at 04:46:01PM +0200, Arnd Bergmann wrote: > On Wednesday 16 July 2008, Grant Likely wrote: > > > > > > > > And then you don't need this file at all.  Just add a > > > "amcc,canyonlands" string to your root node compatible property. > > > > No!  Don't do this because it is no

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Grant Likely
On Wed, Jul 16, 2008 at 10:37:52AM -0400, Josh Boyer wrote: > On Wed, 16 Jul 2008 08:15:39 -0600 > Grant Likely <[EMAIL PROTECTED]> wrote: > > > On Wed, Jul 16, 2008 at 07:50:25AM -0400, Josh Boyer wrote: > > > And then you don't need this file at all. Just add a > > > "amcc,canyonlands" string t

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Arnd Bergmann
On Wednesday 16 July 2008, Grant Likely wrote: > > > > > And then you don't need this file at all.  Just add a > > "amcc,canyonlands" string to your root node compatible property. > > No!  Don't do this because it is not true! > > Instead, add your board name to canyonlands.c in canyonlands_pro

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Josh Boyer
On Wed, 16 Jul 2008 08:15:39 -0600 Grant Likely <[EMAIL PROTECTED]> wrote: > On Wed, Jul 16, 2008 at 07:50:25AM -0400, Josh Boyer wrote: > > On Tue, 15 Jul 2008 22:33:26 -0700 > > [EMAIL PROTECTED] wrote: > > > > > From: Victor Gallardo <[EMAIL PROTECTED]> > > > > > > ppc4xx: Add AMCC Arches 460

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Grant Likely
On Wed, Jul 16, 2008 at 07:50:25AM -0400, Josh Boyer wrote: > On Tue, 15 Jul 2008 22:33:26 -0700 > [EMAIL PROTECTED] wrote: > > > From: Victor Gallardo <[EMAIL PROTECTED]> > > > > ppc4xx: Add AMCC Arches 460GT eval board support > > > > Signed-off-by: Victor Gallardo <[EMAIL PROTECTED]> > > Fr

Re: [PATCH] Add AMCC Arches 460GT eval board support to platforms/44x

2008-07-16 Thread Josh Boyer
On Tue, 15 Jul 2008 22:33:26 -0700 [EMAIL PROTECTED] wrote: > From: Victor Gallardo <[EMAIL PROTECTED]> > > ppc4xx: Add AMCC Arches 460GT eval board support > > Signed-off-by: Victor Gallardo <[EMAIL PROTECTED]> >From what I can tell, you don't even need this patch or the defconfig. Nothing di