Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

2011-07-12 Thread Tony Breeds
On Tue, Jul 12, 2011 at 02:04:04PM -0400, Josh Boyer wrote: > On Tue, Jul 12, 2011 at 12:40:07PM -0500, Ayman El-Khashab wrote: > >On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote: > >> All current pcie controllers unconditionally use SDR to check the link and > >> poll for reset. > > >

Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

2011-07-12 Thread Tony Breeds
On Tue, Jul 12, 2011 at 05:13:38PM -0500, Ayman El-Khashab wrote: > Ok, so let me ask the following ... will it cause trouble if > I swap the sequence of the calls to the following in xxx_port_init > > ppc4xx_pciex_port_init_mapping(...) > > and > > if (ppc4xx_pciex_hwops->check_link)... > > T

Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

2011-07-12 Thread Ayman El-Khashab
On Tue, Jul 12, 2011 at 02:04:04PM -0400, Josh Boyer wrote: > On Tue, Jul 12, 2011 at 12:40:07PM -0500, Ayman El-Khashab wrote: > >On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote: > >> All current pcie controllers unconditionally use SDR to check the link and > >> poll for reset. > > >

Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

2011-07-12 Thread Josh Boyer
On Tue, Jul 12, 2011 at 12:40:07PM -0500, Ayman El-Khashab wrote: >On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote: >> All current pcie controllers unconditionally use SDR to check the link and >> poll for reset. > >I was able to apply this patch and then modify the 460SX to >work corre

Re: [PATCH] 4xx: Add check_link to struct ppc4xx_pciex_hwops

2011-07-12 Thread Ayman El-Khashab
On Fri, Jul 01, 2011 at 04:44:24PM +1000, Tony Breeds wrote: > All current pcie controllers unconditionally use SDR to check the link and > poll for reset. I was able to apply this patch and then modify the 460SX to work correctly, so I think it is fine. There is only 1 comment below. So how doe