On Thu, 7 Aug 2008, Paul Mackerras wrote:
>
> I think you want "return -ENOIOCTLCMD" rather than "return ret" since
> ret is uninitialized with your patch applied.
Actually, nobody has apparently ever even tried compiling that function
even before.
Yes, 'ret' became uninitialized, but since
On Thu, 7 Aug 2008 09:43:28 +1000
Paul Mackerras <[EMAIL PROTECTED]> wrote:
> Alan Cox writes:
>
> > --- a/drivers/char/viocons.c
> > +++ b/drivers/char/viocons.c
> > @@ -705,10 +705,6 @@ static int viotty_ioctl(struct tty_struct *tty, struct
> > file *file,
> > case KDSKBLED:
> >
Alan Cox writes:
> --- a/drivers/char/viocons.c
> +++ b/drivers/char/viocons.c
> @@ -705,10 +705,6 @@ static int viotty_ioctl(struct tty_struct *tty, struct
> file *file,
> case KDSKBLED:
> return 0;
> }
> - /* FIXME: WTF is this being called for ??? */
> - lock_
On Thu, Aug 07, 2008 at 12:10:06AM +1000, Stephen Rothwell wrote:
> Hi Alan,
>
> On Wed, 6 Aug 2008 14:06:29 +0100 Alan Cox <[EMAIL PROTECTED]> wrote:
> >
> > The iSeries driver calls into the n_tty ldisc code directly for some
> > bizarre reason. I previously tagged this with a query but this act
Hi Alan,
On Wed, 6 Aug 2008 14:06:29 +0100 Alan Cox <[EMAIL PROTECTED]> wrote:
>
> The iSeries driver calls into the n_tty ldisc code directly for some
> bizarre reason. I previously tagged this with a query but this actually
> does need fixing as n_tty methods when you have a different ldisc set
