Re: [EDAC PATCH v13 4/7] edac: move nr_pages to dimm struct

2012-04-18 Thread Mauro Carvalho Chehab
Em 17-04-2012 18:40, Borislav Petkov escreveu: > On Tue, Apr 17, 2012 at 04:28:49PM -0300, Mauro Carvalho Chehab wrote: >> Ok. well, we can either multiply nr_pages by channel_count or to let it >> clear that this is per channel. I prefer the last option (see the enclosed >> patch). >> @@ -215

Re: [EDAC PATCH v13 4/7] edac: move nr_pages to dimm struct

2012-04-17 Thread Borislav Petkov
On Tue, Apr 17, 2012 at 04:28:49PM -0300, Mauro Carvalho Chehab wrote: > Ok. well, we can either multiply nr_pages by channel_count or to let it > clear that this is per channel. I prefer the last option (see the enclosed > patch). > > >> @@ -2152,6 +2146,7 @@ static int init_csrows(struct mem_ctl

Re: [EDAC PATCH v13 4/7] edac: move nr_pages to dimm struct

2012-04-17 Thread Borislav Petkov
On Mon, Apr 16, 2012 at 05:12:10PM -0300, Mauro Carvalho Chehab wrote: > The number of pages is a dimm property. Move it to the dimm struct. > > After this change, it is possible to add sysfs nodes for the DIMM's that Minor nitpick:

Re: [EDAC PATCH v13 4/7] edac: move nr_pages to dimm struct

2012-04-17 Thread Mauro Carvalho Chehab
Em 17-04-2012 15:48, Borislav Petkov escreveu: > On Mon, Apr 16, 2012 at 05:12:10PM -0300, Mauro Carvalho Chehab wrote: >> The number of pages is a dimm property. Move it to the dimm struct. >> >> After this change, it is possible to add sysfs nodes for the DIMM's that > > Minor nitpick: > >