Re: [2/3][PATCH][v2] TDM Framework

2012-08-21 Thread Mark Brown
On Wed, Aug 01, 2012 at 05:37:38AM -0700, Greg KH wrote: > On Wed, Aug 01, 2012 at 12:13:19PM +, Singh Sandeep-B37400 wrote: > > But running a complete voice stack itself is beyond the scope of Freescale. > > So vendors integrate their solutions with FSL solution. > And sorry, I was thinking

Re: [2/3][PATCH][v2] TDM Framework

2012-08-01 Thread Greg KH
On Wed, Aug 01, 2012 at 12:13:19PM +, Singh Sandeep-B37400 wrote: > > On Mon, Jul 30, 2012 at 09:50:57AM +, Singh Sandeep-B37400 wrote: > > > 1. You should send some kernel mode TDM clients. Without those the > > framework > > >is pretty useless. > > > [Sandeep] We do have a test client

RE: [2/3][PATCH][v2] TDM Framework

2012-08-01 Thread Singh Sandeep-B37400
.infradead.org; linux-ker...@vger.kernel.org > Subject: Re: [2/3][PATCH][v2] TDM Framework > > On Mon, Jul 30, 2012 at 09:50:57AM +, Singh Sandeep-B37400 wrote: > > 1. You should send some kernel mode TDM clients. Without those the > framework > >is pretty useless. &

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Singh Sandeep-B37400
; linux-ker...@vger.kernel.org Subject: Re: [2/3][PATCH][v2] TDM Framework On Fri, Jul 27, 2012 at 05:25:42PM +0200, Francois Romieu wrote: > 2. It would probably make sense to Cc: netdev and serial. There may be >some kernel client network integration from the start. Plus audio, quite a

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Singh Sandeep-B37400
...@driverdev.osuosl.org Subject: RE: [2/3][PATCH][v2] TDM Framework >>>>> "Singh" == Singh Sandeep-B37400 writes: Singh> -Original Message- Singh> From: John Stoffel [mailto:j...@stoffel.org] Singh> Sent: 27 July 2012 19:42 Singh> To: Singh Sandeep-B37400 Sin

Re: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Greg KH
On Mon, Jul 30, 2012 at 09:50:57AM +, Singh Sandeep-B37400 wrote: > 1. You should send some kernel mode TDM clients. Without those the framework >is pretty useless. > [Sandeep] We do have a test client but not good enough to be pushed in > open source, should we add it to documentation??

Re: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Mark Brown
On Fri, Jul 27, 2012 at 05:25:42PM +0200, Francois Romieu wrote: > 2. It would probably make sense to Cc: netdev and serial. There may be >some kernel client network integration from the start. Plus audio, quite a few of the buses mentioned as examples of use cases for the hardware are audio

Re: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Greg KH
July 27, 2012 11:30 PM > > To: Singh Sandeep-B37400 > > Cc: de...@driverdev.osuosl.org; linuxppc-dev@lists.ozlabs.org; linux-arm- > > ker...@lists.infradead.org; linux-ker...@vger.kernel.org > > Subject: Re: [2/3][PATCH][v2] TDM Framework > > > > On Fri, Jul 2

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread John Stoffel
inux-arm-ker...@lists.infradead.org; ga...@kernel.crashing.org; linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org Singh> Subject: Re: [2/3][PATCH][v2] TDM Framework >> From: Sandeep Singh TDM Framework is an >> attempt to provide a platform independent layer which can offer a >> s

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Singh Sandeep-B37400
...@lists.infradead.org; de...@driverdev.osuosl.org; ga...@kernel.crashing.org; linux-ker...@vger.kernel.org Subject: Re: [2/3][PATCH][v2] TDM Framework On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > +static DEFINE_MUTEX(tdm_core_lock); > +static DEFINE_IDR(tdm_adapter_idr); > +/

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Singh Sandeep-B37400
...@kernel.crashing.org; linux-ker...@vger.kernel.org; de...@driverdev.osuosl.org Subject: Re: [2/3][PATCH][v2] TDM Framework sand...@freescale.com : [...] > The main functions of this Framework are: > - provides interface to TDM clients to access TDM functionalities. > - provides standard interfac

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Singh Sandeep-B37400
/3][PATCH][v2] TDM Framework > From: Sandeep Singh TDM Framework is an > attempt to provide a platform independent layer which can offer a > standard interface for TDM access to different client modules. Please don't use TLAs (Three Letter Acronyms) like TDM without explaining th

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Aggrwal Poonam-B10812
ozlabs.org; linux-arm- > ker...@lists.infradead.org; linux-ker...@vger.kernel.org > Subject: Re: [2/3][PATCH][v2] TDM Framework > > On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > > +static struct kobj_type tdm_type = { > > + .sysfs_ops

RE: [2/3][PATCH][v2] TDM Framework

2012-07-30 Thread Aggrwal Poonam-B10812
ozlabs.org; linux-arm- > ker...@lists.infradead.org; linux-ker...@vger.kernel.org > Subject: Re: [2/3][PATCH][v2] TDM Framework > > On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > > +/* Data structures required for sysfs */ static struct tdm_sysfs attr > &g

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread John Stoffel
> From: Sandeep Singh > TDM Framework is an attempt to provide a platform independent layer which can > offer a standard interface for TDM access to different client modules. Please don't use TLAs (Three Letter Acronyms) like TDM without explaining the clearly and up front. It makes it hard fo

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > +static struct kobj_type tdm_type = { > + .sysfs_ops = &tdm_ops, > + .default_attrs = tdm_attr, > +}; Ah, also, as per the documentation in the kernel (go look, it's there), I now get to publicly mock you for ignoring

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread Greg KH
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > +/* Data structures required for sysfs */ > +static struct tdm_sysfs attr = { > + .attr.name = "use_latest_data", > + .attr.mode = 0664, > + .cmd_type = TDM_LATEST_DATA, > +}; What is this for? > +int tdm_sysfs_i

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread Francois Romieu
sand...@freescale.com : [...] > The main functions of this Framework are: > - provides interface to TDM clients to access TDM functionalities. > - provides standard interface for TDM drivers to hook with the framework. > - handles various data handling stuff and buffer management. > > In futur

Re: [2/3][PATCH][v2] TDM Framework

2012-07-27 Thread Russell King - ARM Linux
On Fri, Jul 27, 2012 at 07:35:38PM +0530, sand...@freescale.com wrote: > +static DEFINE_MUTEX(tdm_core_lock); > +static DEFINE_IDR(tdm_adapter_idr); > +/* List of TDM adapters registered with TDM framework */ > +LIST_HEAD(adapter_list); > + > +/* List of TDM clients registered with TDM framework */