Re: [03/12,v3] pci: fsl: add PCI indirect access support

2014-01-06 Thread Scott Wood
On Mon, 2014-01-06 at 13:36 +0800, Lian Minghuan-b31939 wrote: > HI Scott, > > please see my comments inline. > > On 01/04/2014 06:33 AM, Scott Wood wrote: > > A lot of this seems duplicated from arch/powerpc/sysdev/indirect_pci.c. > > > > How generally applicable is that file to non-PPC implemen

Re: [03/12,v3] pci: fsl: add PCI indirect access support

2014-01-05 Thread Lian Minghuan-b31939
HI Scott, please see my comments inline. On 01/04/2014 06:33 AM, Scott Wood wrote: On Wed, Oct 23, 2013 at 06:41:25PM +0800, Minghuan Lian wrote: The patch adds PCI indirect read/write functions. The main code is ported from arch/powerpc/sysdev/indirect_pci.c. We use general IO API iowrite32be

Re: [03/12,v3] pci: fsl: add PCI indirect access support

2014-01-03 Thread Scott Wood
On Wed, Oct 23, 2013 at 06:41:25PM +0800, Minghuan Lian wrote: > The patch adds PCI indirect read/write functions. The main code > is ported from arch/powerpc/sysdev/indirect_pci.c. We use general > IO API iowrite32be/ioread32be instead of out_be32/in_be32, and > use structure fsl_Pci instead of Po