Re: RFC: Only deal with apple fix if res is memory

2008-01-12 Thread Kumar Gala
On Jan 11, 2008, at 4:03 PM, Benjamin Herrenschmidt wrote: > > On Fri, 2008-01-11 at 10:38 -0600, Kumar Gala wrote: >> Ben, >> >> Will this impact the apple fix? I'm getting some _IO cases hitting >> this. > > No, your fix is right, it's a bug to compare against pci_mem_offset > and > not ch

Re: RFC: Only deal with apple fix if res is memory

2008-01-11 Thread Benjamin Herrenschmidt
On Fri, 2008-01-11 at 10:38 -0600, Kumar Gala wrote: > Ben, > > Will this impact the apple fix? I'm getting some _IO cases hitting this. No, your fix is right, it's a bug to compare against pci_mem_offset and not check if it's a memory resource in the first place. I would suggest that you do th

RFC: Only deal with apple fix if res is memory

2008-01-11 Thread Kumar Gala
Ben, Will this impact the apple fix? I'm getting some _IO cases hitting this. - k diff --git a/arch/powerpc/kernel/pci-common.c b/arch/powerpc/kernel/pci-common.c index d394d41..42a9dab 100644 --- a/arch/powerpc/kernel/pci-common.c +++ b/arch/powerpc/kernel/pci-common.c @@ -807,6 +807,7 @@ stat