Re: RFC: MPC5200 PSC AC97 driver

2008-04-22 Thread Olaf Hering
On Thu, Apr 17, Juergen Beisert wrote: > if someone is interested: Here the full patch to get sound support for > MPC5200b and a current 2.6.25 kernel. It misses a 'MODULE_DEVICE_TABLE(of, mpc52xx_ac97_of_match);' and a nul termination of struct mpc52xx_ac97_of_match. This will allow autoload of

Re: RFC: MPC5200 PSC AC97 driver

2008-04-21 Thread Matt Sealey
Juergen Beisert wrote: Please don't forget what Sylvian said about this driver: "I also completely skipped the 5200 (not B) support ..." and your own "I think it should be left noted here that the CCR size changed from 16 bits to 32 bits from 5200 to 5200B in order to reduce confusion.". Its

Re: RFC: MPC5200 PSC AC97 driver

2008-04-21 Thread Juergen Beisert
Matt, On Saturday 19 April 2008 14:02, Matt Sealey wrote: > Grant Likely wrote: > > On Fri, Apr 18, 2008 at 12:11 PM, Matt Sealey <[EMAIL PROTECTED]> wrote: > >> Juergen Beisert wrote: > > > > BTW, is anyone trying to shepherd this driver into the ALSA tree? Its > > out of my area of expertise a

Re: RFC: MPC5200 PSC AC97 driver

2008-04-19 Thread Grant Likely
On Fri, Apr 18, 2008 at 9:43 AM, Peter Czanik <[EMAIL PROTECTED]> wrote: > Hello, > > factory:/usr/src/linux-2.6.25 # diff -u > arch/powerpc/kernel/prom_init.c.orig arch/powerpc/kernel/prom_init.c > --- arch/powerpc/kernel/prom_init.c.orig2008-04-18 > 13:55:07.0 +0200 > +++ arch/

Re: RFC: MPC5200 PSC AC97 driver

2008-04-19 Thread Grant Likely
On Sat, Apr 19, 2008 at 6:02 AM, Matt Sealey <[EMAIL PROTECTED]> wrote: > > Grant Likely wrote: > > > > > On Fri, Apr 18, 2008 at 12:11 PM, Matt Sealey <[EMAIL PROTECTED]> wrote: > > > > > Juergen Beisert wrote: > > > > > > > BTW, is anyone trying to shepherd this driver into the ALSA tree? Its

Re: RFC: MPC5200 PSC AC97 driver

2008-04-19 Thread Matt Sealey
Grant Likely wrote: On Fri, Apr 18, 2008 at 12:11 PM, Matt Sealey <[EMAIL PROTECTED]> wrote: Juergen Beisert wrote: BTW, is anyone trying to shepherd this driver into the ALSA tree? Its out of my area of expertise and responsibility, so I haven't been pursuing it. We (well, I) were going t

Re: RFC: MPC5200 PSC AC97 driver

2008-04-18 Thread Grant Likely
On Fri, Apr 18, 2008 at 12:11 PM, Matt Sealey <[EMAIL PROTECTED]> wrote: > > Juergen Beisert wrote: > > > > > On Friday 18 April 2008 17:43, Peter Czanik wrote: > > > > I'm not sure if "cell-index" is a correct property. I copied it from the > uart driver, because this driver needs something to di

Re: RFC: MPC5200 PSC AC97 driver

2008-04-18 Thread Matt Sealey
Juergen Beisert wrote: On Friday 18 April 2008 17:43, Peter Czanik wrote: I'm not sure if "cell-index" is a correct property. I copied it from the uart driver, because this driver needs something to distinguish between PSC1 and PSC2. Maybe there is a better and correct oftree solution? Any oft

Re: RFC: MPC5200 PSC AC97 driver

2008-04-18 Thread Juergen Beisert
On Friday 18 April 2008 17:43, Peter Czanik wrote: > Hello, > > Juergen Beisert írta: > > Hi, > > > > if someone is interested: Here the full patch to get sound support for > > MPC5200b and a current 2.6.25 kernel. > > First of all, thanks for fixing the driver. I just tested it on the > EFIKA, it

Re: RFC: MPC5200 PSC AC97 driver

2008-04-18 Thread Peter Czanik
Hello, Juergen Beisert írta: Hi, if someone is interested: Here the full patch to get sound support for MPC5200b and a current 2.6.25 kernel. First of all, thanks for fixing the driver. I just tested it on the EFIKA, it (almost) works. In its current state loading the kernel module results

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Sergei Shtylyov
Matt Sealey wrote: +/* the fifo starts right after psc ends */ +priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1];/* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct mpc52xx_psc)); Be a little less obtuse use of C? "priv->psc" is

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: On Thursday 17 April 2008 17:10, Matt Sealey wrote: Juergen Beisert wrote: Hi, + /* the fifo starts right after psc ends */ + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->ps

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 17:05, Matt Sealey wrote: > > + help > > + Say Y or M if you want to support any AC97 codec attached to > > + the Freescqle MPC52xx AC97 interface. > > Also this; Freescale :) yes. ;-) -- Dipl.-Ing. Juergen Beisert | http://www.pengutronix.de  Pengutronix - Li

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 17:10, Matt Sealey wrote: > Juergen Beisert wrote: > > Hi, > > + /* the fifo starts right after psc ends */ > > + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ > > Wouldn't > > priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(stru

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: Hi, + /* the fifo starts right after psc ends */ + priv->fifo = (struct mpc52xx_psc_fifo*)&priv->psc[1]; /* FIXME */ Wouldn't priv->fifo = (struct mpc52xx_psc_fifo*) (priv->psc + sizeof(struct mpc52xx_psc)); Be a little less obtuse use of C? I jus

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
+ help + Say Y or M if you want to support any AC97 codec attached to + the Freescqle MPC52xx AC97 interface. Also this; Freescale :) -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations ___ Linuxppc-dev mailin

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: On Thursday 17 April 2008 16:23, Matt Sealey wrote: Hooray! :) Does it work, though, with your board? - u16 ccr;/* PSC + 0x20 */ - u8 reserved7[14]; + u32 ccr;/* PSC + 0x20 */ + u32

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
On Thursday 17 April 2008 16:23, Matt Sealey wrote: > Hooray! :) > > Does it work, though, with your board? > > > - u16 ccr;/* PSC + 0x20 */ > > - u8 reserved7[14]; > > + u32 ccr;/* PSC + 0x20 */ > > + u32 ac97_slots;

Re: RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Matt Sealey
Juergen Beisert wrote: Hi, Hooray! :) Does it work, though, with your board? - u16 ccr;/* PSC + 0x20 */ - u8 reserved7[14]; + u32 ccr;/* PSC + 0x20 */ + u32 ac97_slots; /* PSC + 0x24 */ I

RFC: MPC5200 PSC AC97 driver

2008-04-17 Thread Juergen Beisert
Hi, if someone is interested: Here the full patch to get sound support for MPC5200b and a current 2.6.25 kernel. Index: sound/ppc/Kconfig === --- sound/ppc/Kconfig.orig 2008-04-17 15:33:27.0 +0200 +++ sound/ppc/Kconfig