> > > The udelay just doesn't make sense to what you are talking about.
> > >
> > > Does SAI really need 10us delay between two register-updating?
> > >
> >
> > No, this is not must be.
>
> Then you should explain in your comments why you really put it here or
> just drop it if it's just a mistake
On Wed, Nov 20, 2013 at 11:37:45AM +0800, Xiubo Li-B47053 wrote:
>
> > The udelay just doesn't make sense to what you are talking about.
> >
> > Does SAI really need 10us delay between two register-updating?
> >
>
> No, this is not must be.
Then you should explain in your comments why you rea
> The udelay just doesn't make sense to what you are talking about.
>
> Does SAI really need 10us delay between two register-updating?
>
No, this is not must be.
> We basically use udelay only if the IP hardware actually needs it: some
> IP needs time to boot itself up after doing software re
On Tue, Nov 05, 2013 at 03:21:49AM +, Li Xiubo wrote:
> As your opinions, should I move the four register writing operations to
> .set_sysclk/set_clkdiv/... functions too ?
> Or just add a clk_disable_unprepare() after them here, and then add
> clk_prepare_enable in one of .set_sysclk/set_cl
> > > >> If there are any comments that say PPC but are not PPC-specific,
> that
> > > >> >should be fixed.
> > > > Yes, find it.
> > > >
> > > > The comments is in "sound/soc/fsl/Makefile" :
> > > > +++
> > > > "# Freescale PowerPC SSI/DMA Platform Support"
> > > > ---
> > > >
> >
On Wed, Nov 06, 2013 at 03:53:24AM +, Li Xiubo wrote:
> > >> If there are any comments that say PPC but are not PPC-specific, that
> > >> >should be fixed.
> > > Yes, find it.
> > >
> > > The comments is in "sound/soc/fsl/Makefile" :
> > > +++
> > > "# Freescale PowerPC SSI/DMA Platform
> >> If there are any comments that say PPC but are not PPC-specific, that
> >> >should be fixed.
> > Yes, find it.
> >
> > The comments is in "sound/soc/fsl/Makefile" :
> > +++
> > "# Freescale PowerPC SSI/DMA Platform Support"
> > ---
> >
> > But fsl-spdif.o is also under it.
> >
Li Xiubo wrote:
If there are any comments that say PPC but are not PPC-specific, that
>should be fixed.
Yes, find it.
The comments is in "sound/soc/fsl/Makefile" :
+++
"# Freescale PowerPC SSI/DMA Platform Support"
---
But fsl-spdif.o is also under it.
And this is also support
> > But fsl-ssi.o and fsl-spdif.o is based PowrePC platform? Which we can
> see from the comments.
>
> fsl_ssi was originally PPC-only, but it now supports PPC and ARM. You
> can see that from the git history.
>
> If there are any comments that say PPC but are not PPC-specific, that
> should be
Li Xiubo wrote:
But fsl-ssi.o and fsl-spdif.o is based PowrePC platform? Which we can see from
the comments.
fsl_ssi was originally PPC-only, but it now supports PPC and ARM. You
can see that from the git history.
If there are any comments that say PPC but are not PPC-specific, that
shoul
> > From the ASoC subsystem comments we can see that:
> > ++
> > Configures the clock dividers. This is used to derive the best DAI bit
> > and frame clocks from the system or master clock. It's best to set the
> > DAI bit and frame clocks as low as possible to save system power.
> > --
>
On Mon, Nov 04, 2013 at 07:35:12AM +, Li Xiubo wrote:
> From the ASoC subsystem comments we can see that:
> ++
> Configures the clock dividers. This is used to derive the best DAI bit and
> frame clocks from the system or master clock. It's best to set the DAI bit
> and frame clocks as low
> > +static int fsl_sai_set_dai_clkdiv(struct snd_soc_dai *cpu_dai,
> > + int div_id, int div)
> > +{
> > + struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
> > + u32 tcr2, rcr2;
> > +
> > + if (div_id == FSL_SAI_TX_DIV) {
> > + tcr2 = readl(sai->base + FSL_SAI_TCR2
On Mon, Nov 04, 2013 at 11:45:10AM +0800, Xiubo Li-B47053 wrote:
> > > +snd-soc-fsl-sai-objs := fsl-sai.o
> >
> > And I think it should be better to put it along with fsl-ssi.o and fsl-
> > spdif.o
> >
>
> But fsl-ssi.o and fsl-spdif.o is based PowrePC platform? Which we can see
> from the comm
> > This adds Freescale SAI ASoC Audio support.
> > This implementation is only compatible with device tree definition.
> > Features:
> > o Supports playback/capture
> > o Supports 16/20/24 bit PCM
> > o Supports 8k - 96k sample rates
> > o Supports slave mode only.
> >
>
> Just for curiosity, I f
On Fri, Nov 01, 2013 at 03:04:48PM +0800, Xiubo Li wrote:
> +static int fsl_sai_set_dai_clkdiv(struct snd_soc_dai *cpu_dai,
> + int div_id, int div)
> +{
> + struct fsl_sai *sai = snd_soc_dai_get_drvdata(cpu_dai);
> + u32 tcr2, rcr2;
> +
> + if (div_id == FSL_SAI_TX_DIV) {
Hi Xiubo,
On Fri, Nov 01, 2013 at 03:04:48PM +0800, Xiubo Li wrote:
> This adds Freescale SAI ASoC Audio support.
> This implementation is only compatible with device tree definition.
> Features:
> o Supports playback/capture
> o Supports 16/20/24 bit PCM
> o Supports 8k - 96k sample rates
> o Sup
17 matches
Mail list logo
