Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2010-07-13 Thread hank peng
Hi: I used your patch and test it on MPC8548 board. Today, I found a problem when doing raid5 recovering. talitos e003.crypto: master data transfer error talitos e003.crypto: xor operation: talitos error -22 [ cut here ] Kernel BUG at c02dcb6c [verbose debug info un

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-26 Thread Ira W. Snyder
On Fri, Dec 18, 2009 at 03:17:42PM -0700, Dan Williams wrote: > On Fri, Dec 18, 2009 at 8:02 AM, Li Yang-R58472 wrote: > > > >>Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for > >>Async_tx XOR offload > >> > >>Ira W. Snyder wrote: > &g

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-18 Thread Dan Williams
On Fri, Dec 18, 2009 at 8:02 AM, Li Yang-R58472 wrote: > >>Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for >>Async_tx XOR offload >> >>Ira W. Snyder wrote: >>> Yes, I have used the device_prep_dma_interrupt() >>functionality quite a >>>

RE: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-18 Thread Li Yang-R58472
>Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for >Async_tx XOR offload > >Ira W. Snyder wrote: >> Yes, I have used the device_prep_dma_interrupt() >functionality quite a >> while back. However, I found it to be pretty much useless. > >The specific case

RE: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-18 Thread Li Yang-R58472
>Subject: Re: [PATCH v2 2/2] Crypto: Talitos: Support for >Async_tx XOR offload > >On Wed, Dec 16, 2009 at 03:47:48PM -0700, Dan Williams wrote: >> Kumar Gala wrote: >> >>> Changes with respect to v1 as per comments received o. >Rebased to >> >>

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Dan Williams
On Thu, Dec 17, 2009 at 11:45 AM, Kumar Gala wrote: >> The specific case it is needed for Talitos/raid is a channel switch >> interrupt.  The interrupt causes the cleanup operation to be run which will >> kick off any pending dependent operations on the xor channel.  In the raid >> case we only

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Kumar Gala
On Dec 17, 2009, at 11:44 AM, Dan Williams wrote: > Ira W. Snyder wrote: >> Yes, I have used the device_prep_dma_interrupt() functionality quite a >> while back. However, I found it to be pretty much useless. > > The specific case it is needed for Talitos/raid is a channel switch > interrupt.

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Dan Williams
Ira W. Snyder wrote: Yes, I have used the device_prep_dma_interrupt() functionality quite a while back. However, I found it to be pretty much useless. The specific case it is needed for Talitos/raid is a channel switch interrupt. The interrupt causes the cleanup operation to be run which wil

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Kumar Gala
On Dec 17, 2009, at 11:09 AM, Ira W. Snyder wrote: > On Wed, Dec 16, 2009 at 03:47:48PM -0700, Dan Williams wrote: >> Kumar Gala wrote: > Changes with respect to v1 as per comments received > o. Rebased to linux-next as of 20091216 > o. The selection is based exclusive of fsldma >

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-17 Thread Ira W. Snyder
On Wed, Dec 16, 2009 at 03:47:48PM -0700, Dan Williams wrote: > Kumar Gala wrote: > >>> Changes with respect to v1 as per comments received > >>> o. Rebased to linux-next as of 20091216 > >>> o. The selection is based exclusive of fsldma > >>> o. Intoduced a new Kernel Configuration variable > >>>

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-16 Thread Dan Williams
Kumar Gala wrote: Changes with respect to v1 as per comments received o. Rebased to linux-next as of 20091216 o. The selection is based exclusive of fsldma o. Intoduced a new Kernel Configuration variable *. This enables selecting the Cryptographic functionality of Talitos along with fsldm

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-16 Thread Kumar Gala
On Dec 16, 2009, at 4:41 PM, Kim Phillips wrote: > On Wed, 16 Dec 2009 21:04:58 +0530 > Vishnu Suresh wrote: > >> Expose Talitos's XOR functionality to be used for >> RAID Parity calculation via the Async_tx layer. >> >> Known Issue: >> When used with fsldma, random crashes are observed >> on

Re: [PATCH v2 2/2] Crypto: Talitos: Support for Async_tx XOR offload

2009-12-16 Thread Kim Phillips
On Wed, 16 Dec 2009 21:04:58 +0530 Vishnu Suresh wrote: > Expose Talitos's XOR functionality to be used for > RAID Parity calculation via the Async_tx layer. > > Known Issue: > When used with fsldma, random crashes are observed > on some platforms. Hence, inter-operability with fsldma > is curre