Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-09-09 Thread Wolfram Sang
> > I would do it in the IO accessors. > > > > Thanks, > Any update for your comment? It is still valid. You can go that road. -- Pengutronix e.K. | Wolfram Sang| Industrial Linux Solutions | http://www.pengutronix.de/ | signature.asc

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-09-09 Thread Zang Roy-R61911
t-B07421 > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > Hello, > > On Fri, Aug 12, 2011 at 09:44:26AM +, Zang Roy-R61911 wrote: > [...] > > > We try to not pollute generic sdhci.c driver with chip-specific > > &g

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-26 Thread Zang Roy-R61911
t-B07421 > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > Hello, > > On Fri, Aug 12, 2011 at 09:44:26AM +, Zang Roy-R61911 wrote: > [...] > > > We try to not pollute generic sdhci.c driver with chip-specific > > &g

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-14 Thread Zang Roy-R61911
t-B07421 > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > Hello, > > On Fri, Aug 12, 2011 at 09:44:26AM +, Zang Roy-R61911 wrote: > [...] > > > We try to not pollute generic sdhci.c driver with chip-specific > > &g

Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-12 Thread Anton Vorontsov
Hello, On Fri, Aug 12, 2011 at 09:44:26AM +, Zang Roy-R61911 wrote: [...] > > We try to not pollute generic sdhci.c driver with chip-specific > > quirks. > > > > Maybe you can do the fixups via IO accessors? Or by introducing > > some additional sdhci op? > Anton, > thanks for the comment, as

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-08-12 Thread Zang Roy-R61911
- > foundation.org; Xu Lei-B33228; Kumar Gala > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > On Fri, Jul 22, 2011 at 06:15:17PM +0800, Roy Zang wrote: > [...] > > if (host->version >= SDHCI_SPEC_200) { > > -

RE: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-07-26 Thread Zang Roy-R61911
- > foundation.org; Xu Lei-B33228; Kumar Gala > Subject: Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl > esdhc > > On Fri, Jul 22, 2011 at 06:15:17PM +0800, Roy Zang wrote: > [...] > > if (host->version >= SDHCI_SPEC_200) { > > -

Re: [PATCH 2/2 v2] eSDHC: Fix errors when booting kernel with fsl esdhc

2011-07-22 Thread Anton Vorontsov
On Fri, Jul 22, 2011 at 06:15:17PM +0800, Roy Zang wrote: [...] > if (host->version >= SDHCI_SPEC_200) { > - ctrl = sdhci_readb(host, SDHCI_HOST_CONTROL); > - ctrl &= ~SDHCI_CTRL_DMA_MASK; > - if ((host->flags & SDHCI_REQ_USE_DMA) && > -