RE: [PATCH 2/2] Make the diu driver work without board level initilization

2014-04-01 Thread jason....@freescale.com
> > Thanks, This has been fixed in the update version, please help to > review it at: > > http://patchwork.ozlabs.org/patch/335225/ > > I forgot to add the V2 information in the subject in the update patch > so this may confuse the reviewer, sorry for that. > > It is not fixed in that patch (or d

Re: [PATCH 2/2] Make the diu driver work without board level initilization

2014-04-01 Thread Scott Wood
On Tue, 2014-04-01 at 02:28 -0500, Jin Zhengxiong-R64188 wrote: > > > + if (!diu_ops.set_pixel_clock) { > > > + data->pixelclk_reg = of_iomap(np, 1); > > > + if (!data->pixelclk_reg) { > > > + dev_err(&pdev->dev, "Cannot map pixelclk registers, > > please \ > > > +

RE: [PATCH 2/2] Make the diu driver work without board level initilization

2014-04-01 Thread jason....@freescale.com
> > + if (!diu_ops.set_pixel_clock) { > > + data->pixelclk_reg = of_iomap(np, 1); > > + if (!data->pixelclk_reg) { > > + dev_err(&pdev->dev, "Cannot map pixelclk registers, > please \ > > + provide the diu_ops for pixclk setting > in

RE: [PATCH 2/2] Make the diu driver work without board level initilization

2014-03-31 Thread li.xi...@freescale.com
> @@ -1752,6 +1793,22 @@ static int fsl_diu_probe(struct platform_device *pdev) > goto error; > } > > + if (!diu_ops.set_pixel_clock) { > + data->pixelclk_reg = of_iomap(np, 1); > + if (!data->pixelclk_reg) { > + dev_err(&pdev->de

RE: [PATCH 2/2] Make the diu driver work without board level initilization

2014-03-31 Thread dongsheng.w...@freescale.com
> -Original Message- > From: Linuxppc-dev [mailto:linuxppc-dev- > bounces+b40534=freescale@lists.ozlabs.org] On Behalf Of Jason Jin > Sent: Thursday, March 27, 2014 7:38 PM > To: Wood Scott-B07421; ti...@tabi.org > Cc: linux-fb...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Li Yan