Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-02 Thread Scott Wood
On Thu, 2 Jun 2011 16:25:02 +0400 Dmitry Eremin-Solenikov wrote: > As a device for pci node isn't created, create a special platform_device > for PCI EDAC device on MPC85xx. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > arch/powerpc/sysdev/fsl_pci.c | 33

RE: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-02 Thread David Laight
> > +int __init fsl_add_pci_err(void) > > static :-) and why __ ? aren't such names reserved in the C language for some purpose. David ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-de

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-02 Thread Anton Vorontsov
On Thu, Jun 02, 2011 at 04:25:02PM +0400, Dmitry Eremin-Solenikov wrote: > As a device for pci node isn't created, create a special platform_device > for PCI EDAC device on MPC85xx. > > Signed-off-by: Dmitry Eremin-Solenikov > --- > arch/powerpc/sysdev/fsl_pci.c | 33 ++

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Scott Wood
On Wed, 1 Jun 2011 18:55:35 +0400 Dmitry Eremin-Solenikov wrote: > On 6/1/11, Anton Vorontsov wrote: > > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: > > [...] > > Also, why not add this call to the fsl_add_bridge(), so you > > won't need to touch board files at all.

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Anton Vorontsov
On Wed, Jun 01, 2011 at 06:55:35PM +0400, Dmitry Eremin-Solenikov wrote: > On 6/1/11, Anton Vorontsov wrote: > > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: > > [...] > >> --- a/arch/powerpc/sysdev/fsl_pci.h > >> +++ b/arch/powerpc/sysdev/fsl_pci.h > >> @@ -92,6 +92,7

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Dmitry Eremin-Solenikov
On 6/1/11, Anton Vorontsov wrote: > On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: > [...] >> --- a/arch/powerpc/sysdev/fsl_pci.h >> +++ b/arch/powerpc/sysdev/fsl_pci.h >> @@ -92,6 +92,7 @@ extern int fsl_add_bridge(struct device_node *dev, int >> is_primary); >> extern

Re: [PATCH 1/2] ppc/85xx: create a platform node for PCI EDAC device

2011-06-01 Thread Anton Vorontsov
On Wed, Jun 01, 2011 at 04:28:11PM +0400, Dmitry Eremin-Solenikov wrote: [...] > --- a/arch/powerpc/sysdev/fsl_pci.h > +++ b/arch/powerpc/sysdev/fsl_pci.h > @@ -92,6 +92,7 @@ extern int fsl_add_bridge(struct device_node *dev, int > is_primary); > extern void fsl_pcibios_fixup_bus(struct pci_bus *