RE: [PATCH] ppc44x:PHY fixup for USB on canyonlands board

2010-11-10 Thread Benjamin Herrenschmidt
On Wed, 2010-11-10 at 20:13 +0530, Rupjyoti Sarmah wrote: > >Is this just for canyonlands? If so, it's probably better off in a > >caynonlands specific file, or a function that gets called in the common > >platform file if the model matches canyonlands. It seems a bit overkill > >to introduce an

Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board

2010-11-10 Thread Stefan Roese
On Wednesday 10 November 2010 12:37:15 Rupjyoti Sarmah wrote: > This fix is a reset for USB PHY that requires some amount of time for power > to be stable on Canyonlands. > > Signed-off-by: Rupjyoti Sarmah > --- > arch/powerpc/boot/dts/canyonlands.dts | 11 > arch/powerpc/platforms/44

RE: [PATCH] ppc44x:PHY fixup for USB on canyonlands board

2010-11-10 Thread Rupjyoti Sarmah
>Is this just for canyonlands? If so, it's probably better off in a >caynonlands specific file, or a function that gets called in the common >platform file if the model matches canyonlands. It seems a bit overkill >to introduce an entire new file and Kconfig option for this. We want to have a f

Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board

2010-11-10 Thread Benjamin Herrenschmidt
On Wed, 2010-11-10 at 09:19 -0500, Josh Boyer wrote: > With this being an arch_initcall, it will get called for every kind of > platform in a multi-board kernel. Another reason to only call it from > a > board specific probe function if it really is canyonlands specific. Right. Time to take cany

Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board

2010-11-10 Thread Josh Boyer
On Wed, Nov 10, 2010 at 05:07:15PM +0530, Rupjyoti Sarmah wrote: >This fix is a reset for USB PHY that requires some amount of time for power to >be stable on Canyonlands. > >Signed-off-by: Rupjyoti Sarmah >--- > arch/powerpc/boot/dts/canyonlands.dts | 11 > arch/powerpc/platforms/44x/4