Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-21 Thread Aneesh Kumar K.V
On 5/21/19 9:37 PM, Dan Williams wrote: On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V wrote: Something like the below (Not tested). I am not sure what we will init the page_size for minor version < 3. This will mark the namespace disabled if the PAGE_SIZE and sizeof(struct page) d

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-21 Thread Dan Williams
On Tue, May 21, 2019 at 2:51 AM Aneesh Kumar K.V wrote: > > Dan Williams writes: > > > On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V > > wrote: > >> > >> On 5/14/19 9:42 AM, Dan Williams wrote: > >> > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V > >> > wrote: > >> >> > >> >> On 5/14/19 9

RE: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-21 Thread Elliott, Robert (Servers)
> -Original Message- > From: Linux-nvdimm On Behalf Of > Aneesh Kumar K.V > Sent: Tuesday, May 21, 2019 4:51 AM > Subject: Re: [PATCH] mm/nvdimm: Use correct #defines instead of > opencoding > ... > @@ -36,6 +36,9 @@ struct nd_pfn_sb { > __le32

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-21 Thread Aneesh Kumar K.V
Dan Williams writes: > On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V > wrote: >> >> On 5/14/19 9:42 AM, Dan Williams wrote: >> > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V >> > wrote: >> >> >> >> On 5/14/19 9:28 AM, Dan Williams wrote: >> >>> On Mon, May 13, 2019 at 7:56 PM Aneesh Kuma

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-21 Thread Dan Williams
On Mon, May 13, 2019 at 9:46 PM Aneesh Kumar K.V wrote: > > On 5/14/19 9:42 AM, Dan Williams wrote: > > On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V > > wrote: > >> > >> On 5/14/19 9:28 AM, Dan Williams wrote: > >>> On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V > >>> wrote: > >

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-13 Thread Aneesh Kumar K.V
On 5/14/19 9:42 AM, Dan Williams wrote: On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V wrote: On 5/14/19 9:28 AM, Dan Williams wrote: On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V wrote: The nfpn related change is needed to fix the kernel message "number of pfns truncated from 261734

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-13 Thread Dan Williams
On Mon, May 13, 2019 at 9:05 PM Aneesh Kumar K.V wrote: > > On 5/14/19 9:28 AM, Dan Williams wrote: > > On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V > > wrote: > >> > >> The nfpn related change is needed to fix the kernel message > >> > >> "number of pfns truncated from 2617344 to 163584" > >

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-13 Thread Aneesh Kumar K.V
On 5/14/19 9:28 AM, Dan Williams wrote: On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V wrote: The nfpn related change is needed to fix the kernel message "number of pfns truncated from 2617344 to 163584" The change makes sure the nfpns stored in the superblock is right value. Signed-off-b

Re: [PATCH] mm/nvdimm: Use correct #defines instead of opencoding

2019-05-13 Thread Dan Williams
On Mon, May 13, 2019 at 7:56 PM Aneesh Kumar K.V wrote: > > The nfpn related change is needed to fix the kernel message > > "number of pfns truncated from 2617344 to 163584" > > The change makes sure the nfpns stored in the superblock is right value. > > Signed-off-by: Aneesh Kumar K.V > --- > d