Re: [kbuild-all] Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Chen, Rong A
On 10/20/2022 11:07 PM, Bjorn Helgaas wrote: On Thu, Oct 20, 2022 at 10:13:10PM +0800, kernel test robot wrote: Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master v6.

Re: [kbuild-all] Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Chen, Rong A
On 10/20/2022 9:41 PM, Bjorn Helgaas wrote: On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: Hi Bjorn, I love your patch! Yet something to improve: [auto build test ERROR on helgaas-pci/next] [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master v6.1

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Pali Rohár
On Thursday 20 October 2022 08:45:47 Bjorn Helgaas wrote: > [+cc Pali, heads-up for trivial addition of to > pci-mvebu.c] ... > pci-mvebu.c also relies on getting via > , but it actually depends on of_irq.h, so I'll just > add an irqdomain.h include there. > > Bjorn > Ok, that is fine!

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Bjorn Helgaas
On Thu, Oct 20, 2022 at 10:13:10PM +0800, kernel test robot wrote: > Hi Bjorn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] > [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master > v6.1-rc1 next-20221020] > [If your patch

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Bjorn Helgaas
On Thu, Oct 20, 2022 at 08:41:01AM -0500, Bjorn Helgaas wrote: > On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > [auto build test ERROR on helgaas-pci/next] > > [also build test ERROR on xilinx-xlnx/mast

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Conor Dooley
On Thu, Oct 20, 2022 at 08:45:47AM -0500, Bjorn Helgaas wrote: > [+cc Pali, heads-up for trivial addition of to > pci-mvebu.c] > > On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > > Hi Bjorn, > > > > > > I lo

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Bjorn Helgaas
[+cc Pali, heads-up for trivial addition of to pci-mvebu.c] On Thu, Oct 20, 2022 at 08:20:25AM +0100, Conor Dooley wrote: > On Thu, Oct 20, 2022 at 03:08:50PM +0800, kernel test robot wrote: > > Hi Bjorn, > > > > I love your patch! Yet something to improve: > > > > >> drivers/pci/controller/pci

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-20 Thread Bjorn Helgaas
On Thu, Oct 20, 2022 at 04:09:37PM +0800, kernel test robot wrote: > Hi Bjorn, > > I love your patch! Yet something to improve: > > [auto build test ERROR on helgaas-pci/next] > [also build test ERROR on xilinx-xlnx/master rockchip/for-next linus/master > v6.1-rc1 next-20221020] > [If your patch

RE: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-19 Thread Roy Zang
> -Original Message- > From: Bjorn Helgaas > > From: Bjorn Helgaas > > Many host controller drivers #include even though they > don't need it. Remove the unnecessary #includes. > > Signed-off-by: Bjorn Helgaas > --- > drivers/pci/controller/cadence/pci-j721e.c | 1 - > drivers/

Re: [PATCH] PCI: Remove unnecessary of_irq.h includes

2022-10-19 Thread Conor Dooley
On Wed, Oct 19, 2022 at 02:54:51PM -0500, Bjorn Helgaas wrote: > From: Bjorn Helgaas > > Many host controller drivers #include even though they > don't need it. Remove the unnecessary #includes. > > Signed-off-by: Bjorn Helgaas > drivers/pci/controller/pcie-microchip-host.c | 1 - LGTM... A