Re: [PATCH] Emulate sync instruction variants

2013-07-04 Thread James Yang
On Thu, 4 Jul 2013, Benjamin Herrenschmidt wrote: > On Thu, 2013-07-04 at 09:31 +0100, David Laight wrote: > > Do you need to execute 'sync' here? > > It is worth checking whether the trap entry/exit doesn't > > do an implicit one for you. > > Not really. It does an implicit isync (more than one

Re: [PATCH] Emulate sync instruction variants

2013-07-04 Thread Benjamin Herrenschmidt
On Thu, 2013-07-04 at 09:31 +0100, David Laight wrote: > Do you need to execute 'sync' here? > It is worth checking whether the trap entry/exit doesn't > do an implicit one for you. Not really. It does an implicit isync (more than one even) but not a sync. Cheers, Ben. _

RE: [PATCH] Emulate sync instruction variants

2013-07-04 Thread David Laight
> Reserved fields of the sync instruction have been used for other > instructions (e.g. lwsync). On processors that do not support variants > of the sync instruction, emulate it by executing a sync to subsume the > effect of the intended instruction. ... > + /* Emulate sync instruction variant