Re: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread Nicolin Chen
Hi Shengjiu, On Thu, Feb 28, 2019 at 05:56:31AM +, S.j. Wang wrote: > cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE > should not be in the supported format list. > > Signed-off-by: Shengjiu Wang > --- > sound/soc/codecs/cs42xx8.c | 3 +-- This is for cs42xx8 codec driver, but

RE: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread S.j. Wang
Hi > > cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should > > not be in the supported format list. > > > > Signed-off-by: Shengjiu Wang > > Is the device capable of accepting 32-bit samples, even if it downgrades it to > 24-bit internally? If so, then maybe SNDRV_PCM_FMTBIT_S32_

Re: [PATCH] ASoC: cs42xx8: Remove S32_LE in format list

2019-02-28 Thread Timur Tabi
On 2/27/19 11:56 PM, S.j. Wang wrote: cs42xx8 is a 24-bit A/D and 24-bit D/A device, so the S32_LE should not be in the supported format list. Signed-off-by: Shengjiu Wang Is the device capable of accepting 32-bit samples, even if it downgrades it to 24-bit internally? If so, then maybe SNDR