Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

ar...@pobox.com; >> grant.lik...@secretlab.ca; >> jwbo...@linux.vnet.ibm.com; Sadanand Mutyala >> Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support >> >> Hi John, >> >> Sorry If I'm painting bike-sheds here, just one tiny tweak might b

RE: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

com; Sadanand Mutyala > Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support > > Hi John, > > Sorry If I'm painting bike-sheds here, just one tiny tweak might be in > order to standardise your mutex_unlock exit path: > > > +static int xemacli

RE: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

com; Sadanand Mutyala > Subject: Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support > > Hi John, > > Sorry If I'm painting bike-sheds here, just one tiny tweak might be in > order to standardise your mutex_unlock exit path: Hey John, I prefer burning down bike-s

Re: [PATCH] [V3] net: emaclite: adding MDIO and phy lib support

Hi John, Sorry If I'm painting bike-sheds here, just one tiny tweak might be in order to standardise your mutex_unlock exit path: > +static int xemaclite_mdio_read(struct mii_bus *bus, int phy_id, int reg) > +{ > +       struct net_local *lp = bus->priv; > +       u32 ctrl_reg; > +       u32 rc;