Re: Problem of PowerPc 82xx when using smc

2010-05-21 Thread hellohello
Sent: Saturday, May 22, 2010 10:51 AM Subject: Re: Problem of PowerPc 82xx when using smc > >> Newer kernels support dynamically allocating this parameter RAM. Older >> kernels use whatever u-boot chose. >> >> Why do you want to set it to a particular address? &g

Re: Problem of PowerPc 82xx when using smc

2010-05-21 Thread hellohello
y are you mucking about with this tooth at all? , tooth works well on everyone's mouth, boys and girls as well" - Original Message - From: "Gary Thomas" To: "hellohello" Cc: "Scott Wood" ; Sent: Friday, May 21, 2010 7:20 PM Subject

Re: Problem of PowerPc 82xx when using smc

2010-05-21 Thread hellohello
" Cc: Sent: Saturday, May 22, 2010 1:28 AM Subject: Re: Problem of PowerPc 82xx when using smc > On 05/20/2010 10:33 PM, hellohello wrote: >>> No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication >>> already happens as part of

Re: Problem of PowerPc 82xx when using smc

2010-05-21 Thread Scott Wood
On 05/20/2010 10:33 PM, hellohello wrote: No, it shouldn't -- rx_bd_base is of type "cbd_t *", so the multiplication already happens as part of pointer arithmetic. ---Yes, you are right. I made a basic mistake. But now I have another question. The SMC1 params can be relocated to any offset of t

Re: Problem of PowerPc 82xx when using smc

2010-05-21 Thread Gary Thomas
tform I've ever used, 8xx and 8xxx as well. - Original Message - From: "Scott Wood" To: "hellohello" Cc: Sent: Friday, May 21, 2010 1:06 AM Subject: Re: Problem of PowerPc 82xx when using smc On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote: I f

Re: Problem of PowerPc 82xx when using smc

2010-05-20 Thread hellohello
this code in neither cpm_uart_cpm2.c nor cpm_uart_core.c. Should I add these code to cpm_uart_core.c? --dp_mem = cpm_dpram_addr(0x87fc); --out_be16(dp_mem, SMC1_BASE); - Original Message - From: "Scott Wood" To: "hellohello" Cc: Sent: Friday, May 21, 2010 1:0

Re: Problem of PowerPc 82xx when using smc

2010-05-20 Thread Scott Wood
On Thu, May 20, 2010 at 04:58:27PM +0800, hellohello wrote: > > I find a problem in > drivers/serial/cpm_uart/cpm_uart_cpm2.c: > int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con) > { > ... ... > pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos; > /*The above line sh

Problem of PowerPc 82xx when using smc

2010-05-20 Thread hellohello
I find a problem in drivers/serial/cpm_uart/cpm_uart_cpm2.c: int cpm_uart_allocbuf(struct uart_cpm_port *pinfo, unsigned int is_con) { ... ... pinfo->tx_bd_base = pinfo->rx_bd_base + pinfo->rx_nrfifos; /*The above line should be :*/ pinfo->tx_bd_base = pinfo->rx_bd_base + sizeof(cbd_t) * pinfo->