Re: PowerPC BUG: using smp_processor_id() in preemptible code

2011-02-24 Thread Peter Zijlstra
On Fri, 2011-02-25 at 08:23 +1100, Benjamin Herrenschmidt wrote: > > I don't think that's needed here as there shall be no batching happening > on the vmalloc space, but it can't hurt to merge it regardless :-) Ah, due to the !batch->active thing? OK, then yeah Hugh's bit is sufficient.

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2011-02-24 Thread Benjamin Herrenschmidt
On Thu, 2011-02-24 at 22:07 +0100, Peter Zijlstra wrote: > > Lovely problem :-), benh mentioned it on IRC, but I never got around > to > finding the email thread, thanks for the CC. > > > What would be better for 2.6.38 and 2.6.37-stable? Moving that call > to > > vunmap_page_range back under vb

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2011-02-24 Thread Benjamin Herrenschmidt
On Thu, 2011-02-24 at 12:47 -0800, Hugh Dickins wrote: > Reading back, I see Jeremy suggested moving vb_free()'s call to > vunmap_page_range() back inside vb->lock: it certainly was his moving > the call out from under that lock that brought the issue to my notice; > but it looked as if there were

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2011-02-24 Thread Peter Zijlstra
On Thu, 2011-02-24 at 12:47 -0800, Hugh Dickins wrote: Lovely problem :-), benh mentioned it on IRC, but I never got around to finding the email thread, thanks for the CC. > What would be better for 2.6.38 and 2.6.37-stable? Moving that call to > vunmap_page_range back under vb->lock, or the par

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2011-02-24 Thread Hugh Dickins
On Thu, 30 Dec 2010, Benjamin Herrenschmidt wrote: > On Wed, 2010-12-29 at 14:54 -0800, Hugh Dickins wrote: > > With recent 2.6.37-rc, with CONFIG_PREEMPT=y CONFIG_DEBUG_PREEMPT=y > > on the PowerPC G5, I get spammed by BUG warnings each time I swapoff: > > > > BUG: using smp_processor_id() in pre

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2010-12-30 Thread Benjamin Herrenschmidt
On Wed, 2010-12-29 at 14:54 -0800, Hugh Dickins wrote: > With recent 2.6.37-rc, with CONFIG_PREEMPT=y CONFIG_DEBUG_PREEMPT=y > on the PowerPC G5, I get spammed by BUG warnings each time I swapoff: > > BUG: using smp_processor_id() in preemptible [] code: swapoff/3974 > caller is .hpte_need

Re: PowerPC BUG: using smp_processor_id() in preemptible code

2010-12-29 Thread Jeremy Fitzhardinge
On 12/30/2010 09:54 AM, Hugh Dickins wrote: > With recent 2.6.37-rc, with CONFIG_PREEMPT=y CONFIG_DEBUG_PREEMPT=y > on the PowerPC G5, I get spammed by BUG warnings each time I swapoff: > > BUG: using smp_processor_id() in preemptible [] code: swapoff/3974 > caller is .hpte_need_flush+0x4c/

PowerPC BUG: using smp_processor_id() in preemptible code

2010-12-29 Thread Hugh Dickins
With recent 2.6.37-rc, with CONFIG_PREEMPT=y CONFIG_DEBUG_PREEMPT=y on the PowerPC G5, I get spammed by BUG warnings each time I swapoff: BUG: using smp_processor_id() in preemptible [] code: swapoff/3974 caller is .hpte_need_flush+0x4c/0x2e8 Call Trace: [c001b4a3f830] [c000f3c