Re: PPC4xx ECC Configs, Defines and Source

2008-12-10 Thread Josh Boyer
On Wed, 10 Dec 2008 10:07:16 +0100 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Wednesday 10 December 2008, Benjamin Herrenschmidt wrote: > > > Why is there a need to have so many files? I would think you could > > > have a single file with all the ECC monitoring implementations in it > > > calle

Re: PPC4xx ECC Configs, Defines and Source

2008-12-10 Thread Stefan Roese
On Wednesday 10 December 2008, Benjamin Herrenschmidt wrote: > > Why is there a need to have so many files? I would think you could > > have a single file with all the ECC monitoring implementations in it > > called ppc4xx_ecc.c (or such). Surely they would share some amount > > of code? > > Well

Re: PPC4xx ECC Configs, Defines and Source

2008-12-10 Thread Benjamin Herrenschmidt
> >I thought I might leverage the definitions Stefan Roese came up with for > >u-boot for the base memory controller: > > > >CONFIG_PPC4xx_IBM_SDRAM: Applicable to 405GP, 405CR, 405EP, AP1000, > > and ML2 > >CONFIG_PPC4xx_IBM_DDR: Applicable to 440GP, 44

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Grant Erickson
On 12/8/08 9:57 PM, Stefan Roese wrote: > On Tuesday 09 December 2008, Grant Erickson wrote: >>> Just to make sure, are you planning on just implementing a driver to >>> deal with whatever settings the bootloader configured? E.g., if ECC is >>> enabled deal with correctable/uncorrectable errors an

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Stefan Roese
Hi Grant, On Tuesday 09 December 2008, Grant Erickson wrote: > > Just to make sure, are you planning on just implementing a driver to > > deal with whatever settings the bootloader configured? E.g., if ECC is > > enabled deal with correctable/uncorrectable errors and if not, do > > nothing? Basi

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Grant Erickson
On 12/8/08 3:10 PM, Josh Boyer wrote: > On Mon, 08 Dec 2008 14:08:01 -0800 > Grant Erickson <[EMAIL PROTECTED]> wrote: > > Well, at the moment CONFIG_PPC4xx_IBM_DDR2 doesn't exist, and has no > meaning. Adding a Kconfig option for it just so you can select an ECC > option seems superfluous. Beca

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Josh Boyer
On Mon, 08 Dec 2008 14:08:01 -0800 Grant Erickson <[EMAIL PROTECTED]> wrote: > On 12/8/08 12:21 PM, Josh Boyer wrote: > > On Mon, Dec 08, 2008 at 11:28:15AM -0800, Grant Erickson wrote: > >> Does anyone have any strong preferences on where configurations, > >> definitions > >> and sources for a P

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Grant Erickson
On 12/8/08 12:21 PM, Josh Boyer wrote: > On Mon, Dec 08, 2008 at 11:28:15AM -0800, Grant Erickson wrote: >> Does anyone have any strong preferences on where configurations, definitions >> and sources for a PPC4xx ECC monitoring and reporting driver should go? >> >> Specifically, this concerns ECC

Re: PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Josh Boyer
On Mon, Dec 08, 2008 at 11:28:15AM -0800, Grant Erickson wrote: >Does anyone have any strong preferences on where configurations, definitions >and sources for a PPC4xx ECC monitoring and reporting driver should go? > >Specifically, this concerns ECC handling code for the IBM DDR2 ECC >controller fo

PPC4xx ECC Configs, Defines and Source

2008-12-08 Thread Grant Erickson
Does anyone have any strong preferences on where configurations, definitions and sources for a PPC4xx ECC monitoring and reporting driver should go? Specifically, this concerns ECC handling code for the IBM DDR2 ECC controller found in the 405EX[r], 440SP, 440SPe, 460EX and 460GT. However, I'd lik