Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Kevin Hao
On Wed, Feb 12, 2014 at 12:26:14PM +0100, Sebastian Hesselbarth wrote: > You can cook it down to: > > m = matches; > /* Check against matches without compatible string */ > while (m->name[0] || m->type[0] || m->compatible[0]) { > if (!m->compatible[0] && of_match_ty

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Sebastian Hesselbarth
On 02/12/14 11:31, Kevin Hao wrote: On Wed, Feb 12, 2014 at 09:30:00AM +0100, Sebastian Hesselbarth wrote: On 02/12/2014 06:28 AM, Kevin Hao wrote: On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote: But, the Interrupt Controller (MPIC) goes AWOL and it is down hill from there.

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Arnd Bergmann
On Wednesday 12 February 2014, Sebastian Hesselbarth wrote: > On 02/12/2014 12:38 AM, Stephen N Chivers wrote: > > Sebastian Hesselbarth wrote on > >> I don't think the missing compatible is causing it, but of_serial > >> provides a DT match for .type = "serial" just to fail later on > >> with th

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Kevin Hao
On Wed, Feb 12, 2014 at 09:25:24AM +0100, Sebastian Hesselbarth wrote: > > Hmm, I did a mistake in the patch: > > - while (m->name[0] || m->type[0]) { > + while (m->compatible[0] || m->name[0] || m->type[0]) { > > for the second added match. Otherwise, the matches are not > evaluated dow

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Kevin Hao
On Wed, Feb 12, 2014 at 09:30:00AM +0100, Sebastian Hesselbarth wrote: > On 02/12/2014 06:28 AM, Kevin Hao wrote: > >On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote: > >>But, the Interrupt Controller (MPIC) > >>goes AWOL and it is down hill from there. > >> > >>The MPIC is specifi

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Sebastian Hesselbarth
On 02/12/2014 06:28 AM, Kevin Hao wrote: On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote: But, the Interrupt Controller (MPIC) goes AWOL and it is down hill from there. The MPIC is specified in the DTS as: mpic: pic@4 { interrupt-controll

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-12 Thread Sebastian Hesselbarth
Subject: Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files. On 02/12/2014 12:41 AM, Scott Wood wrote: Regardless of whether .type = "serial" gets removed, it seems wrong for of_match_node() to accept a .type-only match (or .name, or anything else that doesn't invo

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Kevin Hao
On Wed, Feb 12, 2014 at 10:21:58AM +1000, Stephen N Chivers wrote: > But, the Interrupt Controller (MPIC) > goes AWOL and it is down hill from there. > > The MPIC is specified in the DTS as: > > mpic: pic@4 { > interrupt-controller; > #a

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Stephen N Chivers
Linux-3.14-rc2: Order of serial node compatibles in DTS files. > > On 02/12/2014 12:41 AM, Scott Wood wrote: > > On Tue, 2014-02-11 at 23:51 +0100, Sebastian Hesselbarth wrote: > >> On 02/11/2014 11:33 PM, Kumar Gala wrote: > >>> Hmm, > >

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Sebastian Hesselbarth
On 02/12/2014 12:41 AM, Scott Wood wrote: On Tue, 2014-02-11 at 23:51 +0100, Sebastian Hesselbarth wrote: On 02/11/2014 11:33 PM, Kumar Gala wrote: Hmm, Wondering if this caused the issue: commit 105353145eafb3ea919f5cdeb652a9d8f270228e Author: Sebastian Hesselbarth Date: Tue Dec 3 14:52:0

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Sebastian Hesselbarth
On 02/12/2014 12:38 AM, Stephen N Chivers wrote: Sebastian Hesselbarth wrote on On 02/11/2014 11:33 PM, Kumar Gala wrote: On Feb 11, 2014, at 2:57 PM, Stephen N Chivers wrote: I have been trial booting a 3.14-rc2 kernel for a 85xx platform (dtbImage). [...] of_serial f1004500.serial: Unkn

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Scott Wood
On Tue, 2014-02-11 at 23:51 +0100, Sebastian Hesselbarth wrote: > On 02/11/2014 11:33 PM, Kumar Gala wrote: > > Hmm, > > > > Wondering if this caused the issue: > > > > commit 105353145eafb3ea919f5cdeb652a9d8f270228e > > Author: Sebastian Hesselbarth > > Date: Tue Dec 3 14:52:00 2013 +0100 > > >

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Stephen N Chivers
Sebastian Hesselbarth wrote on 02/12/2014 09:51:43 AM: > From: Sebastian Hesselbarth > To: Kumar Gala , Stephen N Chivers > > Cc: linuxppc-dev@lists.ozlabs.org, Chris Proctor > , devicetree , Arnd > Bergmann > Date: 02/12/2014 09:51 AM > Subject: Re: Linux-3.14-r

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Sebastian Hesselbarth
On 02/11/2014 11:33 PM, Kumar Gala wrote: On Feb 11, 2014, at 2:57 PM, Stephen N Chivers wrote: I have been trial booting a 3.14-rc2 kernel for a 85xx platform (dtbImage). After mounting the root filesystem there are no messages from the init scripts and the serial console is not available f

Re: Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Kumar Gala
On Feb 11, 2014, at 2:57 PM, Stephen N Chivers wrote: > I have been trial booting a 3.14-rc2 kernel for a 85xx platform > (dtbImage). > > After mounting the root filesystem there are no messages from the init > scripts > and the serial console is not available for login. > > In the kernel lo

Linux-3.14-rc2: Order of serial node compatibles in DTS files.

2014-02-11 Thread Stephen N Chivers
I have been trial booting a 3.14-rc2 kernel for a 85xx platform (dtbImage). After mounting the root filesystem there are no messages from the init scripts and the serial console is not available for login. In the kernel log messages there is: of_serial f1004500.serial: Unknown serial port foun